>From <ka...@redhat.com>: ka...@redhat.com has uploaded a new change for review.
https://review.gerrithub.io/301790 Change subject: cmake: shared lib FSALs should be MODULE libs, not SHARED libs ...................................................................... cmake: shared lib FSALs should be MODULE libs, not SHARED libs cmake documenation says that, for add_library(), a MODULE is a flavor of shared library that you use dl_open()+dl_sym() on. In general this is a no-op change, except that SuSE, on Leap42, has added --no-undefined to CMAKE_SHARED_LINKER_FLAGS for its rpm builds. Unfortunately it has added --no-undefined to CMAKE_MODULE_LINKER_FLAGS too; which I claim is a mistake. But one that can be worked around without breaking their desired semantics for SHARED libs. But first we need to make our modules into MODULES in cmake. Change-Id: I907e7b6fb2076d2e5451f1959e609930047e85cd Signed-off-by: Kaleb S. KEITHLEY <kkeit...@redhat.com> --- M src/FSAL/FSAL_CEPH/CMakeLists.txt M src/FSAL/FSAL_GLUSTER/CMakeLists.txt M src/FSAL/FSAL_GPFS/CMakeLists.txt M src/FSAL/FSAL_PROXY/CMakeLists.txt M src/FSAL/FSAL_RGW/CMakeLists.txt M src/FSAL/FSAL_VFS/panfs/CMakeLists.txt M src/FSAL/FSAL_VFS/vfs/CMakeLists.txt M src/FSAL/FSAL_VFS/xfs/CMakeLists.txt M src/FSAL/FSAL_ZFS/CMakeLists.txt M src/FSAL/Stackable_FSALs/FSAL_NULL/CMakeLists.txt M src/tracing/CMakeLists.txt 11 files changed, 11 insertions(+), 11 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/90/301790/1 -- To view, visit https://review.gerrithub.io/301790 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I907e7b6fb2076d2e5451f1959e609930047e85cd Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: ka...@redhat.com ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
