On 11/27/16 1:16 AM, Malahal Naineni wrote: > I am not sure about the exact error that the checkpatch is complaining > here. Maybe it is getting confused with our conditionals!
It's complaining about the one line #endif between the beginning and end of the if clause. > About the > _USE_NLM, it is done incorrectly the way I understand it. We should > define P_NLM only if _USE_NLM is defined. Then the current code will > run to compilation issues and fixing them would get the code right! > OK. I'll run this past Dan on Monday (according to blame, that's his). > If the intention is to remove the feature and NOT the code size, then > this could just be a config parameter (enable_NLM = [true]/false) > which will make the code easier to read. Does anyone know the original > intention of _USE_NLM? > Not me. ------------------------------------------------------------------------------ _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
