On 11/29/2016 02:37 AM, William Allen Simpson wrote:
> On 11/28/16 1:28 PM, Malahal Naineni wrote:
>> I think SPLIT_STRING is enabled by default. This supposedly helps some
>> linux kernel hackers to map a given syslog message with the actual
>> code line by simply grepping. Debatable as printk could contain string
>> symbols evading the matches. Enabling this and the 80 character line
>> limit is a mess! Both are debatable. I am for disabling SPLIT_STRING
>> warning from our checkpatch.conf.
>>
>> Any comments to keep it and how useful that was so far? I never really
>> needed it!
>>
>>> When did somebody turn this stupidity on?!?!
>>>
>>> Turn this code-nazi nonsense off!!!!
>>>
> Please turn SPLIT_STRING off.  This was a patch that committed perfectly
> well in the past.  Yet after much work rebasing over the holiday, now
> won't commit at all -- no matter how many hours I've spent massaging it.
>
> SPLIT_STRING makes it really hard to review printf formats.  Because they
> mostly are off the screen, we now never see most of the line without
> tedious scrolling back and forth....
>
> Human readability and code maintainability trump some nitwit using grep.
>
> Do it today, so that next week I can try to commit again!
>

The issue is with the PRIu32 placeholders, which are not part of the 
quoted string (by necessity).  You need to split at those.

Daniel


------------------------------------------------------------------------------
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Reply via email to