>From Malahal <mala...@gmail.com>:
Malahal has uploaded a new change for review. (
https://review.gerrithub.io/344577
Change subject: Fix use after free of a dupreq
......................................................................
Fix use after free of a dupreq
Two threads, one executing nfs_dupreq_rele and the other executing
nfs_dupreq_finish could race each other. nfs_dupreq_rele may make the
the dupreq's ref count zero under dupreq mutex. nfs_dupreq_finish
selects some dupreqs to free, but it doesn't hold their mutex while
doing so.
This results in nfs_dupreq_rele still holding dupreq mutex while
nfs_dupreq_finish freeing the same dupreq. We saw pthread_mutex_destroy
returning EBUSY resulting in aborts.
We have rbtree slot mutex, drc mutex and dupreq mutex locking order.
Rearranged code in nfs_dupreq_start to follow the same locking order.
Change-Id: Id7b04ad902cbd6747b5af33fedb283394fe464b6
Signed-off-by: Malahal Naineni <mala...@us.ibm.com>
---
M src/RPCAL/nfs_dupreq.c
1 file changed, 17 insertions(+), 4 deletions(-)
git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha
refs/changes/77/344577/1
--
To view, visit https://review.gerrithub.io/344577
To unsubscribe, visit https://review.gerrithub.io/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7b04ad902cbd6747b5af33fedb283394fe464b6
Gerrit-Change-Number: 344577
Gerrit-PatchSet: 1
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Owner: Malahal <mala...@gmail.com>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
