On Do, 2017-02-23 at 04:40 -0500, William Allen Simpson wrote: > On 2/23/17 3:43 AM, Swen Schillig wrote: > > > > while removing some legacy GPFS code I stumbled over this > > > > my_fd = (struct gpfs_fd *)(state + 1); > > > > which is probably just copied from an early version to all our > > FSALs. > > > Looks like the state struct is followed by per-FSAL independent data. > > A better design than this (or a union) would be container_of, so that > each FSAL is independent, and needs no centralized union.
True. For me, the main thing was the idea of having it as a part of state_t. I knew some might object to the split alloc idea, that's why I started the discussion with the union. Anyway, all ideas raised so far are better than what's there, so let's see what else is there to come and maybe we can agree to one then. Swen. > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
