But, isn't su_cache...NULL? Matt
----- Original Message ----- > From: "William Allen Simpson" <william.allen.simp...@gmail.com> > To: d...@redhat.com, nfs-ganesha-devel@lists.sourceforge.net > Sent: Thursday, March 9, 2017 1:19:21 PM > Subject: Re: [Nfs-ganesha-devel] UDP duplicate cache in both Ganesha and > ntirpc? > > On 3/9/17 10:12 AM, Daniel Gryniewicz wrote: > > It probably should stay. ntirpc is intended to be useful to more than > > Ganesha, and this seems like a useful feature for potential users. It's > > not the codepaths called by Ganesha, so it doesn't cause any problems. > > > It *is* the codepaths called by Ganesha: > > svc_dg_recv(struct svc_req *req) > { > [...] > req->rq_cksum = > #if 1 > CityHash64WithSeed(iov.iov_base, MIN(256, iov.iov_len), 103); > #else > calculate_crc32c(0, iov.iov_base, MIN(256, iov.iov_len)); > #endif > > if (su->su_cache != NULL) { > if (svc_dg_cache_get(xprt, &req->rq_msg, &reply, &replylen)) > { > > [...] > > svc_dg_reply(struct svc_req *req) > { > [...] > if (sendmsg(xprt->xp_fd, msg, 0) == (ssize_t) slen) { > stat = true; > if (su->su_cache) > svc_dg_cache_set(xprt, slen, > req->rq_msg.rm_xid); > } > > > ------------------------------------------------------------------------------ > Announcing the Oxford Dictionaries API! The API offers world-renowned > dictionary content that is easy and intuitive to access. Sign up for an > account today to start using our lexical data to power your apps and > projects. Get started today and enter our developer competition. > http://sdm.link/oxford > _______________________________________________ > Nfs-ganesha-devel mailing list > Nfs-ganesha-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel > -- Matt Benjamin Red Hat, Inc. 315 West Huron Street, Suite 140A Ann Arbor, Michigan 48103 http://www.redhat.com/en/technologies/storage tel. 734-821-5101 fax. 734-769-8938 cel. 734-216-5309 ------------------------------------------------------------------------------ Announcing the Oxford Dictionaries API! The API offers world-renowned dictionary content that is easy and intuitive to access. Sign up for an account today to start using our lexical data to power your apps and projects. Get started today and enter our developer competition. http://sdm.link/oxford _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel