Daniel, I meant to say - nfs_dupreq_finish doesn't call put_drc always. It does only if it meets certain criteria (drc_should_retire). Say the maxsize is 1000, hiwat is 800 and retire window size = 0. At the time of unmount if the drc size is just 100 wouldn't the refcount stay > 0.
Thanks, Satya. >nfs_dupreq_finish() calls dupreq_entry_put() at about line 1238, and >nfs_dupreq_put_drc() at about line 1222, so I think this is okay. >Daniel >On 05/01/2017 11:08 AM, Satya Prakash GS wrote: >> Hi, >> >> DRC refcnt is incremented on every get_drc. However, every >> nfs_dupreq_finish doesn't call a put_drc. How is it ensured that the >> drc refcnt drops to zero. On doing an umount, is drc eventually >> cleaned up. >> >> Thanks, >> Satya. >> >> ------------------------------------------------------------------------------ >> Check out the vibrant tech community on one of the world's most >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >> _______________________________________________ >> Nfs-ganesha-devel mailing list >> Nfs-ganesha-devel@... >> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel >> On Mon, May 1, 2017 at 9:09 PM, Matt Benjamin <mbenja...@redhat.com> wrote: > Hi Satya, > > I don't -think- that's the case (that DRCs are leaked). If so, we would > certainly wish to correct it. Malahal has most recently updated these code > paths. > > Regards, > > Matt > > ----- Original Message ----- >> From: "Satya Prakash GS" <g.satyaprak...@gmail.com> >> To: nfs-ganesha-devel@lists.sourceforge.net >> Sent: Monday, May 1, 2017 11:08:48 AM >> Subject: [Nfs-ganesha-devel] drc refcnt >> >> Hi, >> >> DRC refcnt is incremented on every get_drc. However, every >> nfs_dupreq_finish doesn't call a put_drc. How is it ensured that the >> drc refcnt drops to zero. On doing an umount, is drc eventually >> cleaned up. >> >> Thanks, >> Satya. >> >> ------------------------------------------------------------------------------ >> Check out the vibrant tech community on one of the world's most >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >> _______________________________________________ >> Nfs-ganesha-devel mailing list >> Nfs-ganesha-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel >> > > -- > Matt Benjamin > Red Hat, Inc. > 315 West Huron Street, Suite 140A > Ann Arbor, Michigan 48103 > > http://www.redhat.com/en/technologies/storage > > tel. 734-821-5101 > fax. 734-769-8938 > cel. 734-216-5309 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
