BLKID only affects a small number of closely related pretty stable functions,
so it may not be worth doing. On the other hand, if we have a bunch of small
isolated conditional compiles, they can all be turned opposite of default in a
single config.
There are a few pervasive conditional compiles that intertwine that should be
tested in all combinations (both on, both off, both senses of one on one off).
Frank
From: Malahal Naineni [mailto:mala...@gmail.com]
Sent: Tuesday, May 9, 2017 6:52 AM
To: d...@redhat.com
Cc: nfs-ganesha-devel@lists.sourceforge.net
Subject: Re: [Nfs-ganesha-devel] Conditional compile failures
By 'VFS' you mean USE_FSAL_VFS ? It is like any other fsal, correct. I want
add _VALGRIND_MEMCHECK as well to the list although it is only used by GPFS
fsal at the moment. We also use _MSPAC_SUPPORT
Others that could be of interest (I don't know much about them though)
LTTng
RDMA
_NO_PORTMAPPER
BLKID/UID
BLKIN tracing
Regards, Malahal.
On Tue, May 9, 2017 at 5:43 PM, Daniel Gryniewicz <d...@redhat.com
<mailto:d...@redhat.com> > wrote:
I read this as meaning that we should add the CI settings in as cmake
options, so devs can easily reproduce those builds. This is probably a
good idea. It does not seem that CMake supports random config settings,
so we'd have to write a wrapper for that, which seems problematic. But
having a few preset common configs that both devs and the CI can run is
probably a good idea.
Do people have suggestions? My list would be:
VFS
DBUS
9P
NFS3/NLM
VSOCK
ADMIN_TOOLS/GUI_ADMIN_TOOLS
Daniel
On 05/08/2017 12:33 PM, Frank Filz wrote:
> I’ve tried building with different cmake options, and half the time I
> don’t succeed in getting the cache cleared correctly…
>
>
>
> Plus we have to train everyone to run all those configs…
>
>
>
> Much easier to use CI to run the various configs. And for anything
> compile/build related, I don’t have a problem if the CI immediately
> starts issuing Verify-1. If there’s a build option set someone thinks
> might be relevant that we don’t succeed in compiling for, we need to fix
> it immediately.
>
>
>
> Frank
>
>
>
> *From:*Malahal Naineni [mailto:mala...@gmail.com <mailto:mala...@gmail.com> ]
> *Sent:* Monday, May 8, 2017 9:01 AM
> *To:* Frank Filz <ffilz...@mindspring.com <mailto:ffilz...@mindspring.com> >
> *Cc:* nfs-ganesha-devel@lists.sourceforge.net
> <mailto:nfs-ganesha-devel@lists.sourceforge.net>
> *Subject:* Re: [Nfs-ganesha-devel] Conditional compile failures
>
>
>
> If we make those as some kind of cmake build configs, then developers
> can also build those combinations before we push our code for review.
> Maybe, have randconfig as well for developers to use but don't enforce
> in CI for the time being (until it has some run time!)
>
>
>
> Regards, malahal.
>
>
>
> On Mon, May 8, 2017 at 9:19 PM, Frank Filz <ffilz...@mindspring.com
> <mailto:ffilz...@mindspring.com>
> <mailto:ffilz...@mindspring.com <mailto:ffilz...@mindspring.com> >> wrote:
>
> Every once in a while we get a report of a build failure from
> someone using
> build options other than what we normally build with.
>
> I'd like to propose that we pick some common combinations folks
> might like
> to build with and have those as part of one of our CI tests run on every
> patch since that is totally the type of thing that's easy to
> automate and a
> royal pain to test manually.
>
> Frank
>
>
> ---
> This email has been checked for viruses by Avast antivirus software.
> https://www.avast.com/antivirus
>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Nfs-ganesha-devel mailing list
> Nfs-ganesha-devel@lists.sourceforge.net
> <mailto:Nfs-ganesha-devel@lists.sourceforge.net>
> <mailto:Nfs-ganesha-devel@lists.sourceforge.net
> <mailto:Nfs-ganesha-devel@lists.sourceforge.net> >
> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
>
>
>
>
> <https://www.avast.com/sig-email?utm_medium=email
> <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient&utm_term=icon>
>
> &utm_source=link&utm_campaign=sig-email&utm_content=emailclient&utm_term=icon>
> Virus-free. www.avast.com <http://www.avast.com>
> <https://www.avast.com/sig-email?utm_medium=email
> <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient&utm_term=link>
>
> &utm_source=link&utm_campaign=sig-email&utm_content=emailclient&utm_term=link>
>
>
> <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>
>
>
> _______________________________________________
> Nfs-ganesha-devel mailing list
> Nfs-ganesha-devel@lists.sourceforge.net
> <mailto:Nfs-ganesha-devel@lists.sourceforge.net>
> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
<mailto:Nfs-ganesha-devel@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
