I find this example of constant on the left less clear, to be honest.
Matt
----- Original Message -----
> From: "William Allen Simpson" <william.allen.simp...@gmail.com>
> To: "NFS Ganesha Developers" <nfs-ganesha-devel@lists.sourceforge.net>
> Sent: Wednesday, June 28, 2017 8:41:26 PM
> Subject: [Nfs-ganesha-devel] commit test Comparisons
>
> This is a good programming practice of long-standing value.
>
> Why of why do these evil commit tests keep creeping in?
>
> bill@simpson91:~/rdma/nfs-ganesha$ git commit --amend -a
> WARNING: Comparisons should place the constant on the right side of the test
> #17: FILE: src/MainNFSD/nfs_rpc_dispatcher_thread.c:1777:
> + if (XPRT_DONE <= stat) {
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Nfs-ganesha-devel mailing list
> Nfs-ganesha-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
>
--
Matt Benjamin
Red Hat, Inc.
315 West Huron Street, Suite 140A
Ann Arbor, Michigan 48103
http://www.redhat.com/en/technologies/storage
tel. 734-821-5101
fax. 734-769-8938
cel. 734-216-5309
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
