On 9/12/17 1:25 PM, William Allen Simpson wrote:
On 9/12/17 10:12 AM, GerritHub wrote:
william.allen.simp...@gmail.com has uploaded this change for *review*.
View Change <https://review.gerrithub.io/378137>
NTIRPC should configure exactly like Ganesha. It's less confusing.
On the ticket, Frank made a number of suggestions. I've done most of
them. There are now explicitly equivalent parallel debug_flags
combinations for errors, warnings, events, and debug.
Moving the RPC_Debug_Flags parameter itself into the LOG block causes a
stack error, so I probably did it wrong. Took that out again.
Along the way, I discovered and fixed a couple of bugs. In the
default logging commit case, the NTIRPC function calls for warnx,
malloc, etc, weren't setup until later (dispatch). Moved that code
into nfs_main.c before doing any logging. It didn't crash because
there are default functions in NTIRPC. But we really wanted the
Ganesha-linked versions, even in early initialization.
Also, if present the RPC_Debug_Flags parameter would always override
whatever was set by the level parameter. As Frank suggested, it is
now used for the Debug level (matching its name), with Full_Debug
setting all the flags (as Malahal had written last year).
I've split it off from the "faster shutdown" patch, and CEA passes it.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
