Hi, I was looking into NLM locking code for NFSv3. According to NLM/NSM protocols specifications, when server restarts, the client should send nlm4_Lock request with "reclaim" flag set. This reclaim is honored only if "NLM server" is in grace period. However, this code in nlm4_Lock function actually looks if the NFS server is in grace period, instead of checking NLM server.
Also, NLM is used in case of NFSv3 and NFSv3 specs do not define grace period. So, NFSv3 only server will mostly run with "Graceless = true" and the lock recovery will not work on server restarts. So, nfs4_Lock should actually use the NLM server grace period (nlm_grace_tv) for handling reclaims. Since NFSv4 does not use NLM at all, we can assume that NLM code path is useful only for NFSv3. Does this look like a genuine issue? Thanks, Sriram ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
