On 11/2/17 1:01 PM, GerritHub wrote:
Frank Filz *posted comments* on this change.

View Change <https://review.gerrithub.io/385451>

Patch set 1:

(2 comments)

  *

    File src/MainNFSD/nfs_rpc_callback.c: 
<https://review.gerrithub.io/#/c/385451/1/src/MainNFSD/nfs_rpc_callback.c>

      o

        Patch Set #1, Line 74: 
<https://review.gerrithub.io/#/c/385451/1/src/MainNFSD/nfs_rpc_callback.c@74> 
|/* retry timeout default to the moon and back */|

        don't these go back to actual clients?

  *

    File src/Protocols/NLM/sm_notify.c: 
<https://review.gerrithub.io/#/c/385451/1/src/Protocols/NLM/sm_notify.c>

      o

        Patch Set #1, Line 20: |/* retry timeout default to the moon and back 
*/|

        This is going to an actual client, shouldn't we have a longer timeout?

If anything, it's too large.  Do we have any clients on the moon?

It takes approximately 1.26 seconds for light to travel to the moon,
so 2.52 seconds RTT.  Leaves 480 ms of terrestrial latency, enough to
circle the earth a few times....

AWS Network Latency Map reports 282 ms between data centers in
Virginia and Central Asia.  That's worst case.

Also, 3 seconds will easily handle 1500 byte packets over 300 bps
satellite link to any ship anywhere in the world.  I'm pretty sure
most links are faster than that nowadays....

If you have worse links, fix your network.  NFS isn't going to work
well over such links anyway.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Reply via email to