On 11/08/2017 02:41 AM, sriram patil wrote:
Hi,
In the subfsal framework, I see that subfsals can have their own
fsal_obj_handles by implementing vfs_sub_alloc_handle and then use
subfsal specific variables using container_of.
It does not provide same functionality for fsal_export however. There is
no vfs_sub_alloc_export. vfs_create_export just calls gsh_calloc to
allocate vfs_fsal_export, giving no flexibility.
PANFS has its own struct panfs_fsal_export but it is not allocated
anywhere. It still uses container_of on vfs_fsal_export. This looks like
a memory corruption. The last commit in PANFS however is about a year
back, not sure if it is actively developed.
PANFS is unused and unmaintained. We keep it building, but that's it.
Considering the above scenario, it makes sense to have
vfs_sub_alloc_export to allow allocating the wrapper export object. Any
thoughts?
This seems like it was a bug in the original implementation for PanFS.
It probably should be fixed, but the VFS sub_fsal doesn't need it, so it
works for now.
Are you making a new sub_fsal?
Daniel
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
