On Thu, Nov 23, 2017 at 12:27:13PM +0530, Girjesh Rajoria wrote:
> Hi Niels,
>
> Azhar and I, one us would be working on your following patch
> https://review.gerrithub.io/#/c/276608/ .
>
> Please provide some information about what is done and what is pending for
> this patch and also how to test it. So that one of us can take it forward.
>From a comment from Frank on the patch, there is this:
> This will need to be merged with the multi-fd/support_ex work... And
> there's probably protocol layer work to be done to fixup 4.2
> operations under support_ex...
In addition to changing the patch to work with the new nfs-ganesha
internals, you will need to do some tests that the procedure actually
gets sent over the network. To do so, roughly follow this:
0. start a tcpdump capture on the NFS-Ganesha server:
# tcpdump -i any -s 0 -w /var/tmp/nfs-seek.pcap tcp and not port 22
1. mount an nfs-export from the modified nfs-ganesha + FSAL_GLUSTER
2. run a program on the nfs-client that exersises SEEK_DATA/SEEK_HOLE
3. kill the tcpdump and gzip the .pcap file (gzip only, no tar)
4. load the .pcap.gz file in wireshark and look for the SEEK procedure
In order to work on it, the easiest is to prepare your development
environment as described on [1]. After you checked out a working branch
based on the 'next' branch (cmd 'git checkout -t -b wip/gluster/seek next'),
you can try to cherry-pick the patch on top of the latest sources with
'git review -x 276608'. This might fail, and you have to edit+fixup the
changes. Use 'git show' for the files that have troubles, and 'git add
<filename>' after you have fixed the file. Once all files have been
corrected, you can run 'git cherry-pick --continue' to commit the
updated patch to your local repository. Now you can proceed with
building and testing.
Thanks for looking into this, and good luck with the development! Please
keep the nfs-ganesha-devel@ list on CC. Other developers will also be
able to answer your questions when they arrise (I'll be out tomorrow and
next week). Join #ganesha on Freenode IRC for more interactive
discussions if needed.
Niels
1. https://github.com/nfs-ganesha/nfs-ganesha/wiki/DevPolicy#pushing-to-gerrit
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
