Agreed.

Daniel

On 01/30/2018 11:46 PM, Malahal Naineni wrote:
Looking at the code, dupreq2_pkginit() only depends on Ganesha config processing to initialize few things, so it should be OK to call anytime after Ganesha config processing.

Regards, Malahal.

On Wed, Jan 31, 2018 at 8:00 AM, Pradeep <pradeeptho...@gmail.com <mailto:pradeeptho...@gmail.com>> wrote:

    Hi Bill,

    Is it ok to move dupreq2_pkginit() before nfs_Init_svc() so that we
    won't hit the crash below?

    #0  0x00007fb54dd7923b in raise () from /lib64/libpthread.so.0
    #1  0x0000000000442ebd in crash_handler (signo=11,
    info=0x7fb546efc430, ctx=0x7fb546efc300) at
    /usr/src/debug/nfs-ganesha-2.6-rc2/MainNFSD/nfs_init.c:263
    #2  <signal handler called>
    #3  0x00000000004de670 in nfs_dupreq_get_drc (req=0x7fb546422800) at
    /usr/src/debug/nfs-ganesha-2.6-rc2/RPCAL/nfs_dupreq.c:579
    #4  0x00000000004e00bf in nfs_dupreq_start (reqnfs=0x7fb546422800,
    req=0x7fb546422800) at
    /usr/src/debug/nfs-ganesha-2.6-rc2/RPCAL/nfs_dupreq.c:1011
    #5  0x0000000000457825 in nfs_rpc_process_request
    (reqdata=0x7fb546422800) at
    /usr/src/debug/nfs-ganesha-2.6-rc2/MainNFSD/nfs_worker_thread.c:852
    #6  0x00000000004599a7 in nfs_rpc_valid_NFS (req=0x7fb546422800) at
    /usr/src/debug/nfs-ganesha-2.6-rc2/MainNFSD/nfs_worker_thread.c:1555

    (gdb) print drc_st
    $1 = (struct drc_st *) 0x0
    (gdb) print nfs_init.init_complete
    $2 = false

    On Tue, Jan 30, 2018 at 1:39 PM, Matt Benjamin <mbenj...@redhat.com
    <mailto:mbenj...@redhat.com>> wrote:

        reordering, I hope

        Matt

        On Tue, Jan 30, 2018 at 1:40 PM, Pradeep
        <pradeeptho...@gmail.com <mailto:pradeeptho...@gmail.com>> wrote:
         > Hello,
         >
         > It is possible to receive requests anytime after
        nfs_Init_svc() is
         > completed. We initialize several things in nfs_Init() after
        this. This could
         > lead to processing of incoming requests racing with the rest of
         > initialization (ex: dupreq2_pkginit()). Is it possible to
        re-order
         > nfs_Init_svc() so that rest of ganesha is ready to process
        requests as soon
         > as we start listing on the NFS port? Another way is to return
        NFS4ERR_DELAY
         > until 'nfs_init.init_complete' is true. Any thoughts?
         >
         >
         > Thanks,
         > Pradeep
         >
         >
        
------------------------------------------------------------------------------
         > Check out the vibrant tech community on one of the world's most
         > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
         > _______________________________________________
         > Nfs-ganesha-devel mailing list
         > Nfs-ganesha-devel@lists.sourceforge.net
        <mailto:Nfs-ganesha-devel@lists.sourceforge.net>
         >
        https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
        <https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel>
         >



        --

        Matt Benjamin
        Red Hat, Inc.
        315 West Huron Street, Suite 140A
        Ann Arbor, Michigan 48103

        http://www.redhat.com/en/technologies/storage
        <http://www.redhat.com/en/technologies/storage>

        tel. 734-821-5101 <tel:734-821-5101>
        fax. 734-769-8938 <tel:734-769-8938>
        cel. 734-216-5309 <tel:734-216-5309>



    
------------------------------------------------------------------------------
    Check out the vibrant tech community on one of the world's most
    engaging tech sites, Slashdot.org! http://sdm.link/slashdot
    _______________________________________________
    Nfs-ganesha-devel mailing list
    Nfs-ganesha-devel@lists.sourceforge.net
    <mailto:Nfs-ganesha-devel@lists.sourceforge.net>
    https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
    <https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel>




------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot



_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Reply via email to