That's certainly suggestive. I found it hard to believe the red-black tree performance could be that bad, at a loading of 10K items--even inserting, searching, and removing in-order. Then again, I never benchmarked the opr_rbtree code.
If I understand correctly, we always insert records in xid order, and xid is monotonically increasing by 1. I guess pings might come back in any order, but if we assume xids retire in xid order also, and keep a window of 10000 records in-tree, that seems maybe like a reasonable starting point for measuring this? I wrote a gtest program (gerrit) that I think does the above in a single thread, no locks, for 1M cycles (search, remove, insert). On lemon, compiled at O2, the gtest profiling says the test finishes in less than 150ms (I saw as low as 124). That's over 6M cycles/s, I think. Matt Matt On Mon, Mar 12, 2018 at 4:06 PM, William Allen Simpson <[email protected]> wrote: > [These are with a Ganesha that doesn't dupreq cache the null operation.] > > Just how slow is this RB tree? > > Here's a comparison of 1000 entries versus 100 entries in ops per second: > > rpcping tcp localhost threads=5 count=1000 (port=2049 program=100003 > version=3 procedure=0): average 2963.2517, total 14816.2587 > rpcping tcp localhost threads=5 count=1000 (port=2049 program=100003 > version=3 procedure=0): average 3999.0897, total 19995.4486 > > rpcping tcp localhost threads=5 count=100 (port=2049 program=100003 > version=3 procedure=0): average 39738.1842, total 198690.9208 > rpcping tcp localhost threads=5 count=100 (port=2049 program=100003 > version=3 procedure=0): average 39913.1032, total 199565.5161 -- Matt Benjamin Red Hat, Inc. 315 West Huron Street, Suite 140A Ann Arbor, Michigan 48103 http://www.redhat.com/en/technologies/storage tel. 734-821-5101 fax. 734-769-8938 cel. 734-216-5309 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Nfs-ganesha-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
