This list has been deprecated. Please subscribe to the new devel list at 
lists.nfs-ganesha.org.
>From Jeff Layton <jlay...@redhat.com>:

Jeff Layton has uploaded this change for review. ( 
https://review.gerrithub.io/409763


Change subject: RPCAL: size spn buffer large enough to hold any possible value
......................................................................

RPCAL: size spn buffer large enough to hold any possible value

Found via new gcc8 warnings format-truncation warnings:

/home/jlayton/git/nfs-ganesha/src/RPCAL/gss_credcache.c: In function 
‘find_keytab_entry’:
/home/jlayton/git/nfs-ganesha/src/RPCAL/gss_credcache.c:725:36: error: ‘%s’ 
directive output may be truncated writing up to 1024 bytes into a region of 
size 299 [-Werror=format-truncation=]
     snprintf(spn, sizeof(spn), "%s/%s@%s",
                                    ^~
       svcnames[j], myhostname, realm);
                    ~~~~~~~~~~
/home/jlayton/git/nfs-ganesha/src/RPCAL/gss_credcache.c:725:5: note: ‘snprintf’ 
output 3 or more bytes (assuming 1027) into a destination of size 300
     snprintf(spn, sizeof(spn), "%s/%s@%s",
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       svcnames[j], myhostname, realm);
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/jlayton/git/nfs-ganesha/src/RPCAL/gss_credcache.c:716:33: error: ‘%s’ 
directive output may be truncated writing up to 1025 bytes into a region of 
size 300 [-Werror=format-truncation=]
     snprintf(spn, sizeof(spn), "%s@%s", myhostad,
                                 ^~      ~~~~~~~~
/home/jlayton/git/nfs-ganesha/src/RPCAL/gss_credcache.c:716:5: note: ‘snprintf’ 
output 2 or more bytes (assuming 1027) into a destination of size 300
     snprintf(spn, sizeof(spn), "%s@%s", myhostad,
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       realm);
       ~~~~~~

Change-Id: I33d5ad90cb3300ce26580d4e374f5a216d609661
Signed-off-by: Jeff Layton <jlay...@redhat.com>
---
M src/RPCAL/gss_credcache.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/63/409763/1
--
To view, visit https://review.gerrithub.io/409763
To unsubscribe, or for help writing mail filters, visit 
https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I33d5ad90cb3300ce26580d4e374f5a216d609661
Gerrit-Change-Number: 409763
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlay...@redhat.com>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Reply via email to