Hi, Please find attach this patch as a mercurial changeset, It's based on the current trunk version.
Regards, Filipe 2013/5/8 Valentin V. Bartenev <[email protected]> > On Thursday 02 May 2013 18:01:29 Filipe Da Silva wrote: > > Hello, Nginx developers, > > > > I been working recently on NGinx, as part of my job . > > > > And I see some small issues as this one : > > > > This call to *ngx_close_connection* is useless as it was already made 18 > > lines before in the code . > > Same code is present in 1.2 > > > > Regards, > > Filipe > > > > ---- > > > > diff -r 8222ca034980 src/mail/ngx_mail_auth_http_module.c > > --- a/src/mail/ngx_mail_auth_http_module.c Tue Apr 02 12:34:39 2013 > > +0000 +++ b/src/mail/ngx_mail_auth_http_module.c Thu May 02 15:46:42 > > 2013 +0200 @@ -696,7 +696,6 @@ > > > > p = ngx_pnalloc(s->connection->pool, ctx->err.len); > > if (p == NULL) { > > - ngx_close_connection(ctx->peer.connection); > > ngx_destroy_pool(ctx->pool); > > ngx_mail_session_internal_server_error(s); > > return; > > The patch looks good for me. It would be nice if you provide it as > a mercurial changeset for pushing. > > wbr, Valentin V. Bartenev >
5198.patch
Description: Binary data
_______________________________________________ nginx-devel mailing list [email protected] http://mailman.nginx.org/mailman/listinfo/nginx-devel
