Hello! On Mon, Jun 27, 2016 at 03:59:26PM -0700, Piotr Sikora wrote:
> # HG changeset patch > # User Piotr Sikora <[email protected]> > # Date 1467064808 25200 > # Mon Jun 27 15:00:08 2016 -0700 > # Node ID 890dc5e6a88c49a9d724cc7da1d0eb20fcc70768 > # Parent d452cb27639f714bc43b7f3ede417e3e7f8efdd6 > Core: remove unused ngx_tm_zone. > > Unused since 9c2f3ed7a247 (0.3.3). > > Signed-off-by: Piotr Sikora <[email protected]> > > diff -r d452cb27639f -r 890dc5e6a88c src/os/unix/ngx_time.h > --- a/src/os/unix/ngx_time.h > +++ b/src/os/unix/ngx_time.h > @@ -38,7 +38,6 @@ typedef struct tm ngx_tm_t; > > #if (NGX_HAVE_GMTOFF) > #define ngx_tm_gmtoff tm_gmtoff > -#define ngx_tm_zone tm_zone > #endif > I would rather preserve this. Both tm_gmtoff and tm_zone are part of a popular extension to struct tm, and tm_zone may be useable in some cases. I see no downsides in preserving it even if it's not used now by nginx itself. -- Maxim Dounin http://nginx.org/ _______________________________________________ nginx-devel mailing list [email protected] http://mailman.nginx.org/mailman/listinfo/nginx-devel
