Hello, Maxim. On 10/26/2016 08:38 PM, Maxim Dounin wrote: > Such a test will fail on versions without variables support in > proxy_method. This is a problem, as the same test suite is used > to test both mainline and stable. To address this we use > conditional TODO tests with version checked: > > diff --git a/proxy_method.t b/proxy_method.t > --- a/proxy_method.t > +++ b/proxy_method.t > @@ -77,9 +77,14 @@ like(http_get('/preserve'), qr/request_m > like(http_get('/const'), qr/request_method=POST/, > 'proxy_method from constant'); > > +TODO: { > +local $TODO = 'not yet' unless $t->has_version('1.11.6'); > + > like(http_get('/var?method=POST'), qr/request_method=POST/, > 'proxy_method from variable'); > > +} > + > like(http_get('/parent/child'), qr/request_method=POST/, > 'proxy_method from parent'); > > Additionally, style is slighly different in our test scripts for > historical reasons, tabs are used to indent perl code. > > Committed with the above changes, thanks. > Sorry for indentation with spaces. I will be more careful.
Thanks. _______________________________________________ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org/mailman/listinfo/nginx-devel