>
> -----Original Message-----
> From: nginx-devel [mailto:[email protected]] On Behalf Of Maxim 
> Dounin
> Sent: Thursday, March 2, 2017 3:37 PM
> To: [email protected]
> Subject: Re: Add missing static specifiers
> 
> Hello!
> 
> On Thu, Mar 02, 2017 at 07:15:25AM +0000, Eran Kornblau wrote:
> 
> [...]
> 
> > > 
> > Fixed, separated the ints and pointers into two blocks (that made more 
> > sense to me than aligning them on a single block)
> 
> Doesn't looks like a good solution to me.  Rather, I would indent pointer 
> names to the appropriate position, much like it is already done slightly 
> above in the same file:
> 
> static ngx_atomic_t   connection_counter = 1;
> ngx_atomic_t         *ngx_connection_counter = &connection_counter;
> 
Fixed

> --
> Maxim Dounin
> http://nginx.org/
> _______________________________________________
> nginx-devel mailing list
> [email protected]
> http://mailman.nginx.org/mailman/listinfo/nginx-devel
> 

Eran

Attachment: nginx-add-static4.patch
Description: nginx-add-static4.patch

_______________________________________________
nginx-devel mailing list
[email protected]
http://mailman.nginx.org/mailman/listinfo/nginx-devel

Reply via email to