> > -----Original Message----- > From: nginx-devel [mailto:nginx-devel-boun...@nginx.org] On Behalf Of Maxim > Dounin > Sent: Monday, August 14, 2017 8:34 PM > To: nginx-devel@nginx.org > Subject: Re: Add support for buffering is scripted logs > > > Ok, so is that a final 'no' for this whole feature, or is there is anything > > else I can do to get this feature in? > > It is certainly not a "final no". As I wrote in the very first comment, a) > it's just a quick note, nothing more, and b) the feature is questionable. If > a good implementation will be submitted, we can consider committing it. > That's good, I thought you were just rejecting politely :)
It would be really great if you could point me to specific parts you think look bad. For example, I'm guessing that you don't like the callbacks I added to open file cache, but I was thinking that it's better to do it this way than to duplicate large chunks of code and write an open file cache specific to log, please let me know if you think otherwise. Any feedback you can provide will be appreciated Thanks Eran > -- > Maxim Dounin > http://nginx.org/ > _______________________________________________ _______________________________________________ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org/mailman/listinfo/nginx-devel
