LGTM

On Sun, Feb 4, 2018 at 8:49 PM, 洪志道 <hongzhi...@gmail.com> wrote:

> Hi!
>
> Maybe it's better to keep the options more complete, and consider the
> follow operation as a mistake.
>
> /usr/local/nginx/sbin/nginx -
>
> hg diff
> diff -r cbf59d483c9c src/core/nginx.c
> --- a/src/core/nginx.c Tue Jan 16 13:52:03 2018 +0300
> +++ b/src/core/nginx.c Sun Feb 04 07:41:36 2018 -0500
> @@ -753,7 +753,12 @@
>              return NGX_ERROR;
>          }
>
> -        while (*p) {
> +        do {
> +
> +            if (*p == '\0') {
> +                ngx_log_stderr(0, "missing option: \"%s\"", argv[i]);
> +                return NGX_ERROR;
> +            }
>
>              switch (*p++) {
>
> @@ -855,7 +860,8 @@
>                  ngx_log_stderr(0, "invalid option: \"%c\"", *(p - 1));
>                  return NGX_ERROR;
>              }
> -        }
> +
> +        } while (*p);
>
>      next:
>
> Thanks.
>
> _______________________________________________
> nginx-devel mailing list
> nginx-devel@nginx.org
> http://mailman.nginx.org/mailman/listinfo/nginx-devel
>
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel

Reply via email to