I agree with Robert.

When adding those new directives, the "default" should match the old
behavior so people who are not aware of the new directives will NOT get any
unexpected results while upgrading to this release. People who has a need
to change the old behavior now will have the new directives in hand.

Can you make keepalive_timeout and keepalive_requests both default to
indefinite?

Thanks!
Frank

On Fri Aug 10 20:50:04 UTC 2018, Robert Paprocki wrote:
> Quite the patch. I recall this behavior being discussed a number of times
> in the past.
>
> Question: why the default of 100? This feels like a significantly breaking
> change wrt. the previous behavior. Are there any plans for advanced
> communication regarding this change, outside of a nominal changelog entry
> (e.g., "introduced 'keepalive_requests' directive")?
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel

Reply via email to