Hi Piotr. On 30/11/2018 18:39, Ruslan Ermilov wrote: > On Thu, Nov 29, 2018 at 06:00:51PM +0300, Maxim Dounin wrote: >> Hello! >> >> On Tue, Nov 27, 2018 at 02:34:10AM -0800, Piotr Sikora via nginx-devel wrote: >> >>> # HG changeset patch >>> # User Piotr Sikora <[email protected]> >>> # Date 1494129075 25200 >>> # Sat May 06 20:51:15 2017 -0700 >>> # Node ID fafbb3ee41e5bb03bcfba73f7d4367b8ab7d36cc >>> # Parent be5cb9c67c05ccaf22dab7abba78aa4c1545a8ee >>> Upstream: added $upstream_bytes_sent variable. >> >> [...] >> >> Ruslan made a similar patch a while ago. It wasn't committed >> since there were questions if such a variable is actually needed - >> I think we are aware of at most one feature request for this: >> >> http://mailman.nginx.org/pipermail/nginx/2018-March/055940.html >> >> I've asked Ruslan to post his version of the patch (or, rather, a >> patch series), please review. > > # HG changeset patch > # User Ruslan Ermilov <[email protected]> > # Date 1543592116 -10800 > # Fri Nov 30 18:35:16 2018 +0300 > # Node ID 79c7b169816cdc63044838b03084c631c0d2f0a3 > # Parent 5cff15dd07cd298e4eff44c04c2833066c217318 > Upstream: style. > > Introduced local variable "c" in ngx_http_upstream_next() and > ngx_http_upstream_finalize_request(). > > No functional changes. > [...] > # HG changeset patch > # User Ruslan Ermilov <[email protected]> > # Date 1543592133 -10800 > # Fri Nov 30 18:35:33 2018 +0300 > # Node ID 95b0ee9297fc3b8782ee1a383e3221b935639cc3 > # Parent 79c7b169816cdc63044838b03084c631c0d2f0a3 > Upstream: implemented $upstream_bytes_sent. > [...]
To make the intention explicit: it would be nice if you do a formal review of these patches. Thanks, Maxim -- Maxim Konovalov _______________________________________________ nginx-devel mailing list [email protected] http://mailman.nginx.org/mailman/listinfo/nginx-devel
