Looks like, we've made a full circle then... I've replied to that suggestion already and in last e-mail (with patch) I note that moving additional logic into the ngx_http_proxy_set_ssl() has its own drawbacks, but I can certainly move more stuff into it.
So do you envision something like "ngx_http_proxy_set_ssl(cf, conf, prev, reuse_ssl)"? As previously we've established that directives merging stays out of ngx_http_proxy_set_ssl (and reuse_ssl calculation has to happen before it). > -----Original Message----- > From: Maxim Dounin <mdou...@mdounin.ru> > Sent: Wednesday, June 15, 2022 17:37 > To: Pavel Pautov via nginx-devel <nginx-devel@nginx.org> > Subject: Re: SSL contexts reuse across locations > > EXTERNAL MAIL: nginx-devel-boun...@nginx.org > > Hello! > > On Tue, Jun 14, 2022 at 05:55:22PM +0000, Pavel Pautov via nginx-devel wrote: > > > Any comments? > > As already suggested in the very first review: > > : You may want to focus on actually making the code more readable > : and abstracting it into ngx_http_proxy_set_ssl() instead. > : Something like ngx_http_upstream_hide_headers_hash() might be a > : good example on how to do it properly. > > Hope this helps. > > -- > Maxim Dounin _______________________________________________ nginx-devel mailing list -- nginx-devel@nginx.org To unsubscribe send an email to nginx-devel-le...@nginx.org
