Hello! On Tue, Aug 30, 2022 at 12:55:39PM +0000, Liam Crilly via nginx-devel wrote:
> # HG changeset patch > # User Liam Crilly <liam.cri...@nginx.com> > # Date 1659696358 -3600 > # Fri Aug 05 11:45:58 2022 +0100 > # Node ID 8781046c34459c05b4d6f296bbbadc3733d51b17 > # Parent 1087570ec093271d10de8e901122c99003a79b6d > Modified layout of navigation menu. > > This patch modifies the layout of the menu navigation with several changes: > - A two-level heirarchy organises content into sections for nginx, other > nginx projects, and information > - The "projects" of njs and unit are moved up, to a more prominent position > - News is moved lower down, to the "info" section. A third menu level > contains the individual years so that the top of the menu is always the > same, regardless of which page you are on. > - Links to external sites are indicated by a right-arrow character First of all, there are various technical issues with the patch, such as: - The list of changes in the commit log suggests there should be a series of patches instead. - There are issues with the two-level hierarchy you are trying to add, notably language selector is on multiple levels at the "news" page (aka site root). - The patch fails due to corrupted japanese characters. Further, I don't think I like the changes suggested. For a number of reasons, in particular: - There are already hierarchy in the menu, though shown with empty lines instead of different margins. Switching to left margins instead looks questionable (especially given than empty lines are preserved, notably on the "news" page after years list), and adding obvious captions to item groups eats space for no apparent reason. - The "news" page is essentially a site root, and moving it to the bottom of the menu looks wrong. Further, the "info/news" block in the resulting layout on the "news" page (aka site root) looks ugly, and combined with the added captions and moved side projects completely hides trac / twitter / blog links on the typical screen. - The site is about nginx, and moving links to side project above the nginx news page looks completely wrong to me. -- Maxim Dounin http://mdounin.ru/ _______________________________________________ nginx-devel mailing list -- nginx-devel@nginx.org To unsubscribe send an email to nginx-devel-le...@nginx.org
