> On 17 Sep 2022, at 01:05, Maxim Dounin <mdou...@mdounin.ru> wrote: > > Hello! > > On Thu, Sep 15, 2022 at 09:42:01AM +0400, Sergey Kandaurov wrote: > >>> On 26 Aug 2022, at 07:01, Maxim Dounin <mdou...@mdounin.ru> wrote: >>> >>> # HG changeset patch >>> # User Maxim Dounin <mdou...@mdounin.ru> >>> # Date 1661481953 -10800 >>> # Fri Aug 26 05:45:53 2022 +0300 >>> # Node ID 84919c2ee8173f704649a8cb4901887e1bf79588 >>> # Parent d5c6eae914325fb6a9b19105fe09aecd04da21e2 >>> SSL: style. >>> >>> Runtime OCSP functions separated from configuration ones. >>> >>> diff --git a/src/event/ngx_event_openssl.h b/src/event/ngx_event_openssl.h >>> --- a/src/event/ngx_event_openssl.h >>> +++ b/src/event/ngx_event_openssl.h >>> @@ -205,10 +205,12 @@ ngx_int_t ngx_ssl_ocsp(ngx_conf_t *cf, n >>> ngx_uint_t depth, ngx_shm_zone_t *shm_zone); >>> ngx_int_t ngx_ssl_ocsp_resolver(ngx_conf_t *cf, ngx_ssl_t *ssl, >>> ngx_resolver_t *resolver, ngx_msec_t resolver_timeout); >>> + >>> ngx_int_t ngx_ssl_ocsp_validate(ngx_connection_t *c); >>> ngx_int_t ngx_ssl_ocsp_get_status(ngx_connection_t *c, const char **s); >>> void ngx_ssl_ocsp_cleanup(ngx_connection_t *c); >>> ngx_int_t ngx_ssl_ocsp_cache_init(ngx_shm_zone_t *shm_zone, void *data); >>> + >>> ngx_array_t *ngx_ssl_read_password_file(ngx_conf_t *cf, ngx_str_t *file); >>> ngx_array_t *ngx_ssl_preserve_passwords(ngx_conf_t *cf, >>> ngx_array_t *passwords); >>> >> >> Speaking of style, this reminds me of various more style issues. > > There was no goal to fix all the style issues. This particular > one interfered with ngx_event_openssl.h changes, hence it was > fixed. > > Note well that a generic rule is to avoid style changes without a > good reason.
Sure, that's rather an observation of what could be done. [..] -- Sergey Kandaurov _______________________________________________ nginx-devel mailing list -- nginx-devel@nginx.org To unsubscribe send an email to nginx-devel-le...@nginx.org
