Hi Maxim,

On 1/23/23 03:59, Maxim Dounin wrote:
# HG changeset patch
# User Maxim Dounin <mdou...@mdounin.ru>
# Date 1674441584 -10800
#      Mon Jan 23 05:39:44 2023 +0300
# Branch quic
# Node ID 849f3b4043ee07a65bbfc4ad136e4246002ec00c
# Parent  6bb884dc72916dc675df65d02abee0c9cfabc916
QUIC: improved SO_COOKIE configure test.

In nginx source code the inttypes.h include, if available, is used to define
standard integer types.  Changed the SO_COOKIE configure test to follow this.

May I ask for curiosity why do you prefer <inttypes.h> for the standard integer types?

Normally, the preferred header file is <stdint.h>, since it's smaller; unless you use the macros or functions from <inttypes.h>, which are things like PRId32, or imaxabs(3).

Is there any portability issue with <stdint.h>?

Thanks,

Alex


diff --git a/auto/os/linux b/auto/os/linux
--- a/auto/os/linux
+++ b/auto/os/linux
@@ -263,7 +263,7 @@ ngx_feature="SO_COOKIE"
  ngx_feature_name="NGX_HAVE_SO_COOKIE"
  ngx_feature_run=no
  ngx_feature_incs="#include <sys/socket.h>
-                  #include <stdint.h>"
+                  $NGX_INCLUDE_INTTYPES_H"
  ngx_feature_path=
  ngx_feature_libs=
  ngx_feature_test="socklen_t optlen = sizeof(uint64_t);
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
https://mailman.nginx.org/mailman/listinfo/nginx-devel

--
<http://www.alejandro-colomar.es/>

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
https://mailman.nginx.org/mailman/listinfo/nginx-devel

Reply via email to