Hello!
On Thu, Jan 26, 2023 at 03:50:47PM +0400, Roman Arutyunyan wrote:
> # HG changeset patch
> # User Roman Arutyunyan <a...@nginx.com>
> # Date 1674649725 -14400
> # Wed Jan 25 16:28:45 2023 +0400
> # Branch quic
> # Node ID 819737783463d7e38ea80109a976db1d3a9bb2db
> # Parent 555913c358221f647bbace26165bef5eb614add4
> HTTP/2: "http2" directive.
>
> The directive enables HTTP/2 in the current server. The previous way to
> enable HTTP/2 via "listen ... http2" is now deprecated.
In no particular order:
- The ngx_http_try_v2() should be a separate patch?
- The "(buf[0] == 'P')" check is not going to work, since valid
HTTP/1.x request can start with 'P' ('POST', 'PATCH', et
cetera). This needs better checking. Further, it's not
guaranteed to arrive in a single packet.
- Virtual servers (and 421), see comments to the first patch.
--
Maxim Dounin
http://mdounin.ru/
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
https://mailman.nginx.org/mailman/listinfo/nginx-devel
