> On 11 Sep 2023, at 15:30, Roman Arutyunyan <a...@nginx.com> wrote: > > # HG changeset patch > # User Roman Arutyunyan <a...@nginx.com> > # Date 1694088909 -14400 > # Thu Sep 07 16:15:09 2023 +0400 > # Node ID 766e9a5771e20cdb3ec41b8001b065ee299ec7ea > # Parent 9ee4158b9d3fa41e647b772e707c29b3e4cb77b5 > Modules compatibility: added QUIC to signature (ticket #2539). > > Enabling QUIC changes ngx_connection_t layout, which is why it should be > added to the signature. >
There are several spare values, such as NGX_MODULE_SIGNATURE_9, unused since initial dynamic modules support in 85dea406e18f. They could be reused without introducing more signature points. > diff --git a/src/core/ngx_module.h b/src/core/ngx_module.h > --- a/src/core/ngx_module.h > +++ b/src/core/ngx_module.h > @@ -191,12 +191,18 @@ > #define NGX_MODULE_SIGNATURE_33 "0" > #endif > > -#if (NGX_COMPAT) > +#if (NGX_QUIC || NGX_COMPAT) > #define NGX_MODULE_SIGNATURE_34 "1" > #else > #define NGX_MODULE_SIGNATURE_34 "0" > #endif > > +#if (NGX_COMPAT) > +#define NGX_MODULE_SIGNATURE_35 "1" > +#else > +#define NGX_MODULE_SIGNATURE_35 "0" > +#endif > + > #define NGX_MODULE_SIGNATURE > \ > NGX_MODULE_SIGNATURE_0 NGX_MODULE_SIGNATURE_1 NGX_MODULE_SIGNATURE_2 > \ > NGX_MODULE_SIGNATURE_3 NGX_MODULE_SIGNATURE_4 NGX_MODULE_SIGNATURE_5 > \ > @@ -209,7 +215,7 @@ > NGX_MODULE_SIGNATURE_24 NGX_MODULE_SIGNATURE_25 NGX_MODULE_SIGNATURE_26 > \ > NGX_MODULE_SIGNATURE_27 NGX_MODULE_SIGNATURE_28 NGX_MODULE_SIGNATURE_29 > \ > NGX_MODULE_SIGNATURE_30 NGX_MODULE_SIGNATURE_31 NGX_MODULE_SIGNATURE_32 > \ > - NGX_MODULE_SIGNATURE_33 NGX_MODULE_SIGNATURE_34 > + NGX_MODULE_SIGNATURE_33 NGX_MODULE_SIGNATURE_34 NGX_MODULE_SIGNATURE_35 > > > #define NGX_MODULE_V1 > \ -- Sergey Kandaurov _______________________________________________ nginx-devel mailing list nginx-devel@nginx.org https://mailman.nginx.org/mailman/listinfo/nginx-devel
