On Fri, Feb 22, 2013 at 10:06:11AM +0800, Weibin Yao wrote: > Use the patch I attached in this mail thread instead, don't use the pull > request patch which is for tengine. > Thanks. >
Oh sorry I missed that attachment. It seems to apply and build OK. I'll start testing it. Thanks! -- Pasi > 2013/2/22 Pasi KÀrkkÀinen <[1][email protected]> > > On Fri, Jan 18, 2013 at 10:38:21AM +0200, Pasi KÀrkkÀinen wrote: > > On Thu, Jan 17, 2013 at 11:15:58AM +0800, ?????? wrote: > > >   Yes. It should work for any request method. > > > > > > > Great, thanks, I'll let you know how it works for me. Probably in two > weeks or so. > > > > Hi, > > Adding the tengine pull request 91 on top of nginx 1.2.7 doesn't work: > > cc1: warnings being treated as errors > src/http/ngx_http_request_body.c: In function > 'ngx_http_read_non_buffered_client_request_body': > src/http/ngx_http_request_body.c:506: error: implicit declaration of > function 'ngx_http_top_input_body_filter' > make[1]: *** [objs/src/http/ngx_http_request_body.o] Error 1 > make[1]: Leaving directory `/root/src/nginx/nginx-1.2.7' > make: *** [build] Error 2 > > ngx_http_top_input_body_filter() cannot be found from any .c/.h files.. > Which other patches should I apply? > > Perhaps this? > > [2]https://github.com/cfsego/limit_upload_rate/blob/master/for-nginx.patch > > Thanks, > -- Pasi > > > > > >   2013/1/16 Pasi KÃ*â*¬rkkÃ*â*¬inen <[1][3][email protected]> > > > > > >    On Sun, Jan 13, 2013 at 08:22:17PM +0800, ?????? wrote: > > >    > Ã*  Ã* This patch should work between nginx-1.2.6 and > nginx-1.3.8. > > >    > Ã*  Ã* The documentation is here: > > > > > >    > Ã*  Ã* ## client_body_postpone_sending ## > > >    > Ã*  Ã* Syntax: **client_body_postpone_sending** `size` > > >    > Ã*  Ã* Default: 64k > > >    > Ã*  Ã* Context: `http, server, location` > > >    > Ã*  Ã* If you specify the `proxy_request_buffering` or > > >    > Ã*  Ã* `fastcgi_request_buffering` to be off, Nginx will > send the body > > >    to backend > > >    > Ã*  Ã* when it receives more than `size` data or the > whole request body > > >    has been > > >    > Ã*  Ã* received. It could save the connection and reduce > the IO number > > >    with > > >    > Ã*  Ã* backend. > > >    > > > >    > Ã*  Ã* ## proxy_request_buffering ## > > >    > Ã*  Ã* Syntax: **proxy_request_buffering** `on | off` > > >    > Ã*  Ã* Default: `on` > > >    > Ã*  Ã* Context: `http, server, location` > > >    > Ã*  Ã* Specify the request body will be buffered to the > disk or not. If > > >    it's off, > > >    > Ã*  Ã* the request body will be stored in memory and sent > to backend > > >    after Nginx > > >    > Ã*  Ã* receives more than `client_body_postpone_sending` > data. It could > > >    save the > > >    > Ã*  Ã* disk IO with large request body. > > >    > > > >    > > > >    > Ã*  Ã*  Ã*  Ã*  Ã*  Ã*  Note that, if you specify it > to be off, the nginx > > >    retry mechanism > > >    > Ã*  Ã* with unsuccessful response will be broken after > you sent part of > > >    the > > >    > Ã*  Ã* request to backend. It will just return 500 when > it encounters > > >    such > > >    > Ã*  Ã* unsuccessful response. This directive also breaks > these > > >    variables: > > >    > Ã*  Ã* $request_body, $request_body_file. You should not > use these > > >    variables any > > >    > Ã*  Ã* more while their values are undefined. > > >    > > > > > > >    Hello, > > > > > >    This patch sounds exactly like what I need aswell! > > >    I assume it works for both POST and PUT requests? > > > > > >    Thanks, > > > > > >    -- Pasi > > > > > >    > Ã*  Ã*  Ã* Hello! > > >    > Ã*  Ã*  Ã* @yaoweibin > > >    > > > >    > Ã*  Ã*  Ã*  Ã* If you are eager for this feature, you > could try my > > >    > Ã*  Ã*  Ã*  Ã* patch: > [2][2][4]https://github.com/taobao/tengine/pull/91. > > >    This patch has > > >    > Ã*  Ã*  Ã*  Ã* been running in our production servers. > > >    > > > >    > Ã*  Ã*  Ã* what's the nginx version your patch based on? > > >    > Ã*  Ã*  Ã* Thanks! > > >    > Ã*  Ã*  Ã* On Fri, Jan 11, 2013 at 5:17 PM, Ã**Ã* > Ã**Ã*°Ã*±Ã*³ > > >    <[3][3][5][email protected]> wrote: > > >    > > > >    > Ã*  Ã*  Ã*  Ã* I know nginx team are working on it. You > can wait for it. > > >    > Ã*  Ã*  Ã*  Ã* If you are eager for this feature, you > could try my > > >    > Ã*  Ã*  Ã*  Ã* patch: > [4][4][6]https://github.com/taobao/tengine/pull/91. > > >    This patch has > > >    > Ã*  Ã*  Ã*  Ã* been running in our production servers. > > >    > > > >    > Ã*  Ã*  Ã*  Ã* 2013/1/11 li zJay > <[5][5][7][email protected]> > > >    > > > >    > Ã*  Ã*  Ã*  Ã*  Ã* Hello! > > >    > Ã*  Ã*  Ã*  Ã*  Ã* is it possible that nginx will not > buffer the client > > >    body before > > >    > Ã*  Ã*  Ã*  Ã*  Ã* handle the request to upstream? > > >    > Ã*  Ã*  Ã*  Ã*  Ã* we want to use nginx as a reverse > proxy to upload very > > >    very big file > > >    > Ã*  Ã*  Ã*  Ã*  Ã* to the upstream, but the default > behavior of nginx is to > > >    save the > > >    > Ã*  Ã*  Ã*  Ã*  Ã* whole request to the local disk > first before handle it > > >    to the > > >    > Ã*  Ã*  Ã*  Ã*  Ã* upstream, which make the upstream > impossible to process > > >    the file on > > >    > Ã*  Ã*  Ã*  Ã*  Ã* the fly when the file is uploading, > results in much high > > >    request > > >    > Ã*  Ã*  Ã*  Ã*  Ã* latency and server-side resource > consumption. > > >    > Ã*  Ã*  Ã*  Ã*  Ã* Thanks! > > >    > Ã*  Ã*  Ã*  Ã*  Ã* > _______________________________________________ > > >    > Ã*  Ã*  Ã*  Ã*  Ã* nginx mailing list > > >    > Ã*  Ã*  Ã*  Ã*  Ã* [6][6][8][email protected] > > >    > Ã*  Ã*  Ã*  Ã*  Ã* > [7][7][9]http://mailman.nginx.org/mailman/listinfo/nginx > > >    > > > >    > Ã*  Ã*  Ã*  Ã* -- > > >    > Ã*  Ã*  Ã*  Ã* Weibin Yao > > >    > Ã*  Ã*  Ã*  Ã* Developer @ Server Platform Team of > Taobao > > >    > Ã*  Ã*  Ã*  Ã* > _______________________________________________ > > >    > Ã*  Ã*  Ã*  Ã* nginx mailing list > > >    > Ã*  Ã*  Ã*  Ã* [8][8][10][email protected] > > >    > Ã*  Ã*  Ã*  Ã* > [9][9][11]http://mailman.nginx.org/mailman/listinfo/nginx > > >    > > > >    > Ã*  Ã*  Ã* > _______________________________________________ > > >    > Ã*  Ã*  Ã* nginx mailing list > > >    > Ã*  Ã*  Ã* [10][10][12][email protected] > > >    > Ã*  Ã*  Ã* > [11][11][13]http://mailman.nginx.org/mailman/listinfo/nginx > > >    > > > >    > Ã*  Ã* -- > > >    > Ã*  Ã* Weibin Yao > > >    > Ã*  Ã* Developer @ Server Platform Team of Taobao > > >    > > > >    > References > > >    > > > >    > Ã*  Ã* Visible links > > >    > Ã*  Ã* 1. mailto:[12][14][email protected] > > >    > Ã*  Ã* 2. > [13][15]https://github.com/taobao/tengine/pull/91 > > >    > Ã*  Ã* 3. mailto:[14][16][email protected] > > >    > Ã*  Ã* 4. > [15][17]https://github.com/taobao/tengine/pull/91 > > >    > Ã*  Ã* 5. mailto:[16][18][email protected] > > >    > Ã*  Ã* 6. mailto:[17][19][email protected] > > >    > Ã*  Ã* 7. > [18][20]http://mailman.nginx.org/mailman/listinfo/nginx > > >    > Ã*  Ã* 8. mailto:[19][21][email protected] > > >    > Ã*  Ã* 9. > [20][22]http://mailman.nginx.org/mailman/listinfo/nginx > > >    > Ã*  10. mailto:[21][23][email protected] > > >    > Ã*  11. > [22][24]http://mailman.nginx.org/mailman/listinfo/nginx > > > > > >    > _______________________________________________ > > >    > nginx mailing list > > >    > [23][25][email protected] > > >    > [24][26]http://mailman.nginx.org/mailman/listinfo/nginx > > > > > >    _______________________________________________ > > >    nginx mailing list > > >    [25][27][email protected] > > >    [26][28]http://mailman.nginx.org/mailman/listinfo/nginx > > > > > >   -- > > >   Weibin Yao > > >   Developer @ Server Platform Team of Taobao > > > > > > References > > > > > >   Visible links > > >   1. mailto:[29][email protected] > > >   2. [30]https://github.com/taobao/tengine/pull/91 > > >   3. mailto:[31][email protected] > > >   4. [32]https://github.com/taobao/tengine/pull/91 > > >   5. mailto:[33][email protected] > > >   6. mailto:[34][email protected] > > >   7. [35]http://mailman.nginx.org/mailman/listinfo/nginx > > >   8. mailto:[36][email protected] > > >   9. [37]http://mailman.nginx.org/mailman/listinfo/nginx > > >  10. mailto:[38][email protected] > > >  11. [39]http://mailman.nginx.org/mailman/listinfo/nginx > > >  12. mailto:[40][email protected] > > >  13. [41]https://github.com/taobao/tengine/pull/91 > > >  14. mailto:[42][email protected] > > >  15. [43]https://github.com/taobao/tengine/pull/91 > > >  16. mailto:[44][email protected] > > >  17. mailto:[45][email protected] > > >  18. [46]http://mailman.nginx.org/mailman/listinfo/nginx > > >  19. mailto:[47][email protected] > > >  20. [48]http://mailman.nginx.org/mailman/listinfo/nginx > > >  21. mailto:[49][email protected] > > >  22. [50]http://mailman.nginx.org/mailman/listinfo/nginx > > >  23. mailto:[51][email protected] > > >  24. [52]http://mailman.nginx.org/mailman/listinfo/nginx > > >  25. mailto:[53][email protected] > > >  26. [54]http://mailman.nginx.org/mailman/listinfo/nginx > > > > > _______________________________________________ > > > nginx mailing list > > > [55][email protected] > > > [56]http://mailman.nginx.org/mailman/listinfo/nginx > > > > _______________________________________________ > > nginx mailing list > > [57][email protected] > > [58]http://mailman.nginx.org/mailman/listinfo/nginx > > _______________________________________________ > nginx mailing list > [59][email protected] > [60]http://mailman.nginx.org/mailman/listinfo/nginx > > -- > Weibin Yao > Developer @ Server Platform Team of Taobao > > References > > Visible links > 1. mailto:[email protected] > 2. https://github.com/cfsego/limit_upload_rate/blob/master/for-nginx.patch > 3. mailto:[email protected] > 4. https://github.com/taobao/tengine/pull/91 > 5. mailto:[email protected] > 6. https://github.com/taobao/tengine/pull/91 > 7. mailto:[email protected] > 8. mailto:[email protected] > 9. http://mailman.nginx.org/mailman/listinfo/nginx > 10. mailto:[email protected] > 11. http://mailman.nginx.org/mailman/listinfo/nginx > 12. mailto:[email protected] > 13. http://mailman.nginx.org/mailman/listinfo/nginx > 14. mailto:[email protected] > 15. https://github.com/taobao/tengine/pull/91 > 16. mailto:[email protected] > 17. https://github.com/taobao/tengine/pull/91 > 18. mailto:[email protected] > 19. mailto:[email protected] > 20. http://mailman.nginx.org/mailman/listinfo/nginx > 21. mailto:[email protected] > 22. http://mailman.nginx.org/mailman/listinfo/nginx > 23. mailto:[email protected] > 24. http://mailman.nginx.org/mailman/listinfo/nginx > 25. mailto:[email protected] > 26. http://mailman.nginx.org/mailman/listinfo/nginx > 27. mailto:[email protected] > 28. http://mailman.nginx.org/mailman/listinfo/nginx > 29. mailto:[email protected] > 30. https://github.com/taobao/tengine/pull/91 > 31. mailto:[email protected] > 32. https://github.com/taobao/tengine/pull/91 > 33. mailto:[email protected] > 34. mailto:[email protected] > 35. http://mailman.nginx.org/mailman/listinfo/nginx > 36. mailto:[email protected] > 37. http://mailman.nginx.org/mailman/listinfo/nginx > 38. mailto:[email protected] > 39. http://mailman.nginx.org/mailman/listinfo/nginx > 40. mailto:[email protected] > 41. https://github.com/taobao/tengine/pull/91 > 42. mailto:[email protected] > 43. https://github.com/taobao/tengine/pull/91 > 44. mailto:[email protected] > 45. mailto:[email protected] > 46. http://mailman.nginx.org/mailman/listinfo/nginx > 47. mailto:[email protected] > 48. http://mailman.nginx.org/mailman/listinfo/nginx > 49. mailto:[email protected] > 50. http://mailman.nginx.org/mailman/listinfo/nginx > 51. mailto:[email protected] > 52. http://mailman.nginx.org/mailman/listinfo/nginx > 53. mailto:[email protected] > 54. http://mailman.nginx.org/mailman/listinfo/nginx > 55. mailto:[email protected] > 56. http://mailman.nginx.org/mailman/listinfo/nginx > 57. mailto:[email protected] > 58. http://mailman.nginx.org/mailman/listinfo/nginx > 59. mailto:[email protected] > 60. http://mailman.nginx.org/mailman/listinfo/nginx > _______________________________________________ > nginx mailing list > [email protected] > http://mailman.nginx.org/mailman/listinfo/nginx _______________________________________________ nginx mailing list [email protected] http://mailman.nginx.org/mailman/listinfo/nginx
