The usual inspection ...
In nglPlugin.h :
- the doc borrowed from nglApplication does not make sense at all (and
the s/app/plugin/ makes some funny nonsense), I'd prefer it to be
'FIXME' for now
- 'extern NGL_API class nglKernel* App;' is already in nglKernel.h where
it belongs (dupe)
- NGL_PLUGIN_USE should not be there as NGL_APP_USE has been deprecated
one month ago (12/03, wow: what old version did you copy/paste ?)
- since it's supposed to be the generic plugin part, that would be nice
not to have the 'Cubase' word here ... Besides trademark infringement :)
In nglPlugin.cpp:
The nglKernel counter should indeed be 0 on creation, and for now the
IncRef() should happen in nglApplication and nglPluginKernel. This came
from the confusion where nglApplication is both a nglKernel user _and_
descendent (for implementation's sake). I'll fix this for the kernel and
application parts.
PS: wow the new files did follow the templates and coding conventions,
and came right in with some doc ! I found my wish for this new year :
may the contributions follow this path :)
Received: from meeloo.net ([62.4.18.112])
by sc8-sf-list1.sourceforge.net with esmtp (Exim 3.31-VA-mm2 #1
(Debian))
id 18V1fJ-0006CX-00
for <[EMAIL PROTECTED]>; Sat, 04 Jan 2003 19:41:33 -0800
Received: from [10.1.1.130] (helo=harry)
by meeloo.net with smtp (Exim 3.36 #1 (Debian))
id 18V1eh-0007Lq-00
for <[EMAIL PROTECTED]>; Sun, 05 Jan 2003 04:40:55 +0100
Message-ID: <[EMAIL PROTECTED]>
From: "Sebastien Metrot" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
References: <[EMAIL PROTECTED]>
Subject: Re: [NGL-devel] Re: Added nglPlugin & nglPluginKernel
MIME-Version: 1.0
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2800.1106
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1106
Sender: [EMAIL PROTECTED]
Errors-To: [EMAIL PROTECTED]
X-BeenThere: [EMAIL PROTECTED]
X-Mailman-Version: 2.0.9-sf.net
Precedence: bulk
Reply-To: [EMAIL PROTECTED]
List-Help: <mailto:[EMAIL PROTECTED]>
List-Post: <mailto:[EMAIL PROTECTED]>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/ngl-devel>,
<mailto:[EMAIL PROTECTED]>
List-Id: NGL developers discussion list <ngl-devel.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/ngl-devel>,
<mailto:[EMAIL PROTECTED]>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum=ngl-devel>
Date: Sat Jan 4 19:43:01 2003
X-Original-Date: Sun, 5 Jan 2003 04:40:42 +0100
----- Original Message -----
From: "Vincent Caron" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Sunday, 05 January, 2003 04:35
Subject: [NGL-devel] Re: Added nglPlugin & nglPluginKernel
The usual inspection ...
In nglPlugin.h :
- the doc borrowed from nglApplication does not make sense at all (and
the s/app/plugin/ makes some funny nonsense), I'd prefer it to be
'FIXME' for now
Right
- 'extern NGL_API class nglKernel* App;' is already in nglKernel.h where
it belongs (dupe)
I was unsure about that and forgot to check
- NGL_PLUGIN_USE should not be there as NGL_APP_USE has been deprecated
one month ago (12/03, wow: what old version did you copy/paste ?)
NGL_APP_USE have been deprecated because App == UserApp (and UserApp don't
even exists globally anymore) however the same is not at all true for
plugins: there is one global UserApp per plugin DLL as it is what represents
de plugin instance (kept that UserApp name for the moment).
- since it's supposed to be the generic plugin part, that would be nice
not to have the 'Cubase' word here ... Besides trademark infringement :)
Hu? I'll check that.
In nglPlugin.cpp:
The nglKernel counter should indeed be 0 on creation, and for now the
IncRef() should happen in nglApplication and nglPluginKernel. This came
from the confusion where nglApplication is both a nglKernel user _and_
descendent (for implementation's sake). I'll fix this for the kernel and
application parts.
Ok.
PS: wow the new files did follow the templates and coding conventions,
and came right in with some doc ! I found my wish for this new year :
may the contributions follow this path :)
Notived that heh? ;)
MeeLoo
