Yeah i actually typed all of that and forgot to apply the comments back in. I'll try to put all the missing comments back in the next patch. i've activated Keep tabs.
Thanks Tariq On Sep 13, 10:52 pm, Dario Quintana <[email protected]> wrote: > I applied the patch partially in (r1015) because: > > - A lot of comments removed from code. I know, they are on Java-syntax, but > don't know why you removed them. > > Please, remember of activate the option "Keep Tabs". > > Thanks and best regards. > > > > On Sun, Sep 13, 2009 at 1:12 AM, karat <[email protected]> wrote: > > > Implemented ShardedSessionImpl and ShardedSessionFactoryImpl and > > dependent classes > > >http://cid-4723b297e3462d1f.skydrive.live.com/self.aspx/Public/cummul... > > > Still need to get the ShardedUUIDGenerator to generate ids :(. > > Hopefully next patch we'll have the intial demo working. > > > Tariq > > > On Sep 10, 10:21 pm, Dario Quintana <[email protected]> > > wrote: > > > Hi > > > > Can you please update your local copy and apply the patch, because it's > > out > > > of date. > > > > Remember the updated code is here now. > >https://nhcontrib.svn.sourceforge.net/svnroot/nhcontrib/trunk/src/NHi... > > > > Thanks for contributing. Cheers. > > > > On Thu, Sep 10, 2009 at 11:36 PM, karat <[email protected]> wrote: > > > > > Patch on rev1014. Atleast the Shards project was compiling i didn't > > > > have much luck with the tests so i haven't uploaded those yet. > > > > Contributing for the first time so i'm sure i've made some mistakes. > > > > I didn't realize we were targetting 3.5 cause i avoided using Linq but > > > > i can refactor some of the code to use some newer features. Also > > > > right now it's a line by line port, even though i know we could > > > > refactor some of the methods, but i know Oren posted not too long > > > > about following the java version so it's easier to maintain, but since > > > > i wasn't sure i kinda stuck with the same flow. > > > > > Tariq > > > > >http://cid-4723b297e3462d1f.skydrive.live.com/self.aspx/Public/patch%. > > .. > > > > > On Sep 10, 12:38 pm, Dario Quintana <[email protected]> > > > > wrote: > > > > > Commited. > > > > > > On Thu, Sep 10, 2009 at 3:14 AM, Timo R <[email protected]> wrote: > > > > > > > I uploaded updated patch based on the new code base on trunk. > > >http://cid-3e70a0794074dd96.skydrive.live.com/self.aspx/.Public/NHibe. > > > > .. > > > > > > > -Timo > > > > > > -- > > > > > Dario Quintanahttp://darioquintana.com.ar > > > > -- > > > Dario Quintanahttp://darioquintana.com.ar > > -- > Dario Quintanahttp://darioquintana.com.ar --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "NHibernate Contrib - Development Group" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com.ar/group/nhcdevs?hl=en -~----------~----~----~----~------~----~------~--~---
