Sourceforge is killing me now. On Fri, Oct 24, 2008 at 9:52 PM, Tuna Toksöz <[EMAIL PROTECTED]> wrote:
> I'll revert the patch, for now and leave the issue open. > > On Fri, Oct 24, 2008 at 9:32 PM, Tuna Toksöz <[EMAIL PROTECTED]> wrote: > >> Hmm, looks like HQL has the same bug, this is why the patch fails. I tried >> to make criteria result transforming stuff similar to hql's. >> >> still investigating. >> >> >> On Fri, Oct 24, 2008 at 9:00 PM, Jesse Napier <[EMAIL PROTECTED]>wrote: >> >>> Ok, cool. I already had a test case so I posted it to the issue. >>> Thanks for reopening this and let me know if you have any questions. >>> >>> >>> >>> Jesse >>> >>> >>> ------------------------------ >>> >>> *From:* [email protected] [mailto: >>> [EMAIL PROTECTED] *On Behalf Of *Tuna Toksöz >>> *Sent:* Friday, October 24, 2008 10:52 AM >>> *To:* [email protected] >>> *Subject:* [nhibernate-development] Re: When a patch breaks code >>> >>> >>> >>> I've just reopened the issue. Please send there a test case >>> >>> http://jira.nhibernate.org/browse/NH-1090 >>> >>> On Fri, Oct 24, 2008 at 8:46 PM, Tuna Toksöz <[EMAIL PROTECTED]> wrote: >>> >>> it was my patch, can you point me to the right direction so that i can >>> reproduce? I pass all the tests currently. >>> >>> >>> >>> On Fri, Oct 24, 2008 at 8:45 PM, Jesse Napier <[EMAIL PROTECTED]> >>> wrote: >>> >>> Hi, >>> >>> There was a recent patch applied on October 21 in revision 3871 which >>> fixes NH-1090, but this patch creates other bugs. The solution to fix the >>> problem I am having is to rollback the patch. >>> >>> >>> >>> So my question is, do I create new bug in jira, and submit the patch as >>> rolling back the old patch or should I just notify the committer so the >>> initial patch can be rollbacked and reworked? It seems to me the better >>> solution would be to communicate with the committer, but that's just my 2 >>> cents. >>> >>> >>> >>> Thanks, >>> >>> Jesse >>> >>> >>> >>> -- >>> Tuna Toksöz >>> >>> Typos included to enhance the readers attention! >>> >>> >>> >>> >>> -- >>> Tuna Toksöz >>> >>> Typos included to enhance the readers attention! >>> >> >> >> >> -- >> Tuna Toksöz >> >> Typos included to enhance the readers attention! >> > > > > -- > Tuna Toksöz > > Typos included to enhance the readers attention! > -- Tuna Toksöz Typos included to enhance the readers attention!
