I checked out the /trunk and quickly surveyed how difficult the move to
Common.Logging would be, and it doesn't look that difficult...
LogManager and ILog are (strikingly) identical between log4net and
Common.Logging, with one small exception.
log4net.ILog has format helper methods like DebugFormat(...);
Common.Logging.ILog does not define format helper methods. The interface
only defines:
public interface ILog
{
// Methods
void Debug(object message);
void Debug(object message, Exception exception);
void Error(object message);
void Error(object message, Exception exception);
void Fatal(object message);
void Fatal(object message, Exception exception);
void Info(object message);
void Info(object message, Exception exception);
void Trace(object message);
void Trace(object message, Exception exception);
void Warn(object message);
void Warn(object message, Exception exception);
// Properties
bool IsDebugEnabled { get; }
bool IsErrorEnabled { get; }
bool IsFatalEnabled { get; }
bool IsInfoEnabled { get; }
bool IsTraceEnabled { get; }
bool IsWarnEnabled { get; }
}
The format helpers are used throughout NH. Any thoughts on how to (or not)
proceed?
----------------------------------------------
Brian Chavez
Bit Armory, Inc.
http://www.bitarmory.com
-----Original Message-----
From: [email protected]
[mailto:[EMAIL PROTECTED] On Behalf Of Berke
Sent: Friday, October 24, 2008 8:32 AM
To: nhibernate-development
Subject: [nhibernate-development] Re: NH Logging Abstraction
I like the idea of making the logging pluggable, its sort of like the
idea of having a common standard interface for IoC containers so that
developers can bring their own IoC to the table and not be forced to
utilize multiple containers.
On Oct 23, 7:40 am, "josh robb" <[EMAIL PROTECTED]> wrote:
> From the trunk.
>
> To be honest - I'd have thought that writing a NLogAppender for
> log4net might solve your problem a _lot_ easier. (Depending on what
> exactly the problem is).
>
> j.
>
>
>
> On Wed, Oct 22, 2008 at 10:58 AM, Brian Chavez <[EMAIL PROTECTED]>
wrote:
> > Hi Fabio,
>
> > I totally understand you guys have other issues that have higher
priority.
>
> > If I submit a patch for this, what "working base" should I make the
patch
> > from? SVN /trunk or off the latest offical src.zip release?
>
> > Thanks,
>
> > Brian
>
> > ----------------------------------------------
> > Brian Chavez
> > Bit Armory, Inc.
> >http://www.bitarmory.com
>
> > From: [email protected]
> > [mailto:[EMAIL PROTECTED] On Behalf Of Fabio
Maulo
> > Sent: Tuesday, October 21, 2008 3:39 PM
> > To: [email protected]
> > Subject: [nhibernate-development] Re: NH Logging Abstraction
>
> > Interesting even if
>
> > "The library is based on work done by the developers of IBatis.NET and
it's
> > usage is inspired by log4net."
>
> > Long work to do in NH and we having some other priority.
>
> > Please create a JIRA about it.
>
> > Thanks.
>
> > 2008/10/21 Brian Chavez <[EMAIL PROTECTED]>
>
> > Hi,
>
> > I just wanted to float the idea of using a Common.Logging abstraction
for
> > NHibernate.
>
> >http://netcommon.sourceforge.net/index.html
>
> > Personally, I've been frustrated by NHibernate's dependency on log4net
for a
> > long time. I use NLog for all my logging in all my apps, and it would
be
> > nice to consolidate NHibernate's logging onto the same logging
> > infrastructure that my application uses.
>
> > I don't see any benefit of having two separate logging infrastructures
and I
> > think NH developers should have the freedom to choose their logging
> > implementation.
>
> > Benefits are:
>
> > 1) I can configure the logging in NHibernate to use log4net or NLog.
>
> > 2) We get more control over logging.
>
> > 3) Impact of switching to Common.Logging should be minimal.
>
> > I just wanted to float the idea with all of you to gauge whether or not
you
> > like the idea. If it's worth exploring, I'll be willing to work on a
patch
> > with Common.Logging.
>
> > Thanks,
>
> > Brian
>
> > ----------------------------------------------
> > Brian Chavez
> > Bit Armory, Inc.
> >http://www.bitarmory.com
>
> > --
> > Fabio Maulo- Hide quoted text -
>
> - Show quoted text -
