Hi, i was just reviewing the patch for NH1621, which adds the 'readonly' accessor.
The patch generally looks alright to me, and all tests still work after applying it. However, the author changed the visibility of the NoopAccessor.NoopSetter from private to internal sealed, so he could return a NoopSetter in the ReadOnlyAccessor's GetSetter method. The NoopAccessor.NoopGetter's visibility was also changed from private to internal sealed, probably to keep the symetry between NoopGetter and NoopSetter. Before committing this, i just wanted to know if anyone can think of a reason why we shouldn't allow the changed visibility of NoopAccessor.NoopGetter and NoopAccessor.NoopSetter? -- Davy Brion http://davybrion.com
