finally been able to fix this.... the bad news is that i had to resort to a bit more parameter bookkeeping, the good news is that the bookkeeping only happens in one class (SqlStringFormatter)
for NH 2.2 (or later), we really should change the way we deal with parameters in general... there are plenty of places in the code where we need parameter-related info, and we typically only pass the info related to that specific part of the code. It would be much easier if we would keep all parameter related info in the Parameter class, and just always pass those instances around IMHO. btw, this fixes NH1609... i don't think it will fix NH1610 which seems to be somewhat unrelated (even though it's listed as a subtask) On Sun, Dec 21, 2008 at 8:46 PM, Davy Brion <[email protected]> wrote: > i haven't been able to fix this in an easy way without breaking something > else... i guess we're better off going with named parameters all the way > > > On Mon, Dec 15, 2008 at 10:52 PM, Fabio Maulo <[email protected]>wrote: > >> 2008/12/15 Davy Brion <[email protected]> >> >>> sounds good, although i think it would be a pretty big change >>> >>> can i try to fix this particular issue with much smaller change first? >>> >> >> Sure. >> >> >>> If i get it working (with all tests passing), i can attach the patch to >>> the issue i created so you can review it before i'd commit it >> >> >> Ok, even if you can review it by your self... you know how: >> 1) all tests passing without change old test or adding the breaking change >> to the releasenote file >> 2) check the implementation in H3.2.6 and comment all difference (as you >> can see if you try to find "different" in the code) >> >> -- >> Fabio Maulo >> > > > > -- > Davy Brion > http://davybrion.com > -- Davy Brion http://davybrion.com
