Just wanted to add my 2 pence to the discussion ... (sorry if it's not
appropriate)
+1 on making the AST the default parser for 2.1GA because ...
1. I'm not sure there are sensible criteria that I (as a user) can apply to
choosing the parser, other than that the NH tests pass/fail (or my system's
tests pass/fail). Asking me which (in general) should be default is not
something I have enough information to decide;
2. From developing code on the NH side of things, I'm not sure I value
correctness over maintainability. I would rather have clean maintainable code
with a couple of bugs (cos that's easy to fix), than have mostly stable code
that's hard to fix bugs in or enhance. Having glanced at the AST code, it
seems infinitely easier to maintain (specifically I was looking at query
parameters where the AST stores them (correctly) in the query, while the
existing parser has them spread out in various bits of the code) - ultimately I
think that's the best criteria to use, making it the obvious choice for the
default.
3. If the tests are all going to run with the AST parser, that makes
supporting the legacy one harder (which compounds point 2).
And of course ... all of this is just my humble opinion.
Cheers,
Richard
From: Fabio Maulo
Sent: Thursday, April 16, 2009 6:39 PM
To: [email protected]
Subject: [nhibernate-development] Re: HQL AST Parser
2009/4/16 Hadi Hariri <[email protected]>
No I haven't tried it yet. I mentioned that we can port two of our apps to
use the new parser, but haven't yet.
don't worry before have a problem to be worried; the software can be fixed ;)
I'll try the new parser with some real-world application too.
--
Fabio Maulo
