First, the "bad decision" thing wasn't meant as criticism - almost the opposite.

Anyhow, I didn't tried, tried and tried to use filters the way I wanted it. I 
used it the way Google said (n)hibernate handles filter. Sure - I probably used 
it the "wrong" way but it suited my needs perfectly.

Patch send to the JIRA
http://nhjira.koah.net/browse/NH-1998

Thanks for all your work
Roger


From: [email protected] 
[mailto:[email protected]] On Behalf Of Fabio Maulo
Sent: den 26 oktober 2009 20:24
To: [email protected]
Subject: [nhibernate-development] Re: Filters & many-to-one - patch welcome?

Now you know that the patch is welcome I would say you a little story about 
"bad decisions".
Some years ago I was needing a way to do something using a framework... I have 
tried and tried and tried until I found a way to do what I was needing.
What sound strange, to me, was the fact that "the door" I found shouldn't work.
Instead base my system in something like that I have reported the bug and 
proposed a new feature.

The end of the story is that, instead of having a really bad surprise when 
someone else found the bug, I have solved my problem, the problem of somebody 
else and the framework had a new feature without the pain of changing my system 
because somebody fix a bug.


2009/10/26 Roger Kratz 
<[email protected]<mailto:[email protected]>>
Hi

I've understood that the breaking change regarding filters and many-to-one is 
here to stay. To see it the positive way - I'm glad to see that even you can 
make bad decisions :).

Anyhow, that's how things are now and I'll better accept it. Me, and I guess a 
lot of other 2.0 users using filters in current apps, will have a real hard 
time upgrading though. Therefore - is a patch welcome regarding this? I can 
spend some time trying to create a patch not disturbing the current code base 
more than necessary.

One way that wouldn't affect current 2.1 users would be to put a flag on 
FilterDefinition, something like...
<filter-def useManyToOne="false">
...which would default to true.

Is a patch like this welcome (or something similar)?

Thanks for all your work
Roger



--
Fabio Maulo

Reply via email to