I added that one for the Linq provider; there were already tests in
place for locate() that were being ignored if the MsSql dialect (or a
couple of others) were in use; I changed those tests so that they now
run when using the MsSql dialect so I think all is good. Being fair,
I didn't test against anything older than sql2008, but to the best of
my knowledge (and I did check the msdn docs) charindex has been around
for some time.
What is the correct procedure for making a change like this?
On 20 Nov 2009, at 16:54, Fabio Maulo wrote:
I don't like to be a watchdog... but
RegisterFunction("locate", new StandardSQLFunction("charindex",
NHibernateUtil.Int32));
in the MsSql dialect, should have a separate commit and a JIRA ticket.
Very minor stuff, I know, but we should try to maintain our quality.
--
Fabio Maulo
