just do it 2010/3/2 Ayende Rahien <[email protected]>
> I am strongly in favor of adding this, as well as adding the pdb for the > release build as well > > > 2010/3/2 Marcin Mikołajczak <[email protected]> > >> Hi, >> >> Is there any reason not to support it for release binaries? This >> eefectively stops any possibility to step into any NHibernate source code >> when running with release binaries. Note that there is no performance >> degradation when using /debug:pdbonly, only slight compilation time >> increase. Please consider this article: >> >> http://www.wintellect.com/CS/blogs/jrobbins/archive/2009/06/19/do-pdb-files-affect-performance.aspx >> >> I am also not necesarily talking about distributing PDB files with the >> release package, if you do not like this idea. If the binaries are at least >> compiled with PDB then we can work around this issue by providing PDBs from >> our own compilation through the SymbolSource symbol server. >> >> Best regards, >> Marcin Mikołajczak >> >> On Tue, Mar 2, 2010 at 4:32 PM, Fabio Maulo <[email protected]> wrote: >> >>> We saw the issue in our JIRA and we will fix it in some moment for the >>> DEBUG compilation (not for release). >>> >>> 2010/3/2 Marcin Mikołajczak <[email protected]> >>> >>> Hi, >>>> >>>> We would like to provide symbol and source server suuport for >>>> NHibernate at http://www.symbolsource.org. Unfortunately, NHibernate >>>> release binaries are not released or even compiled with PDB support. >>>> Would it be possible to enable this in the build system? A similar >>>> question was posted some time ago and issue NH-2046 created for >>>> exactly the same request, but it did not get much attention: >>>> >>>> >>>> http://groups.google.co.uk/group/nhibernate-development/browse_thread/thread/b2835a0455c25e8d/b026b32da8cd3095?hl=en&lnk=gst&q=pdb#b026b32da8cd3095 >>>> >>>> http://216.121.112.228/browse/NH-2046 >>>> >>>> Here is the patch contents for current trunk code: >>>> >>>> Index: build-common/common.xml >>>> =================================================================== >>>> --- build-common/common.xml (revision 4949) >>>> +++ build-common/common.xml (working copy) >>>> @@ -161,7 +161,7 @@ >>>> >>>> <target name="set-release-project-configuration" >>>> description="Perform a 'release' build"> >>>> <property name="build.release" value="true" /> >>>> - <property name="build.debug" value="false" /> >>>> + <property name="build.debug" value="pdbonly" /> >>>> <property name="build.name" >>>> value="NHibernate-${project.version}" / >>>> > >>>> </target> >>>> >>>> Our goal is to be able to support the next 3.0 (pre-)release and any >>>> releases that come after that. SymbolSource is a new project that aims >>>> at providing a public symbol and source server for widely used open >>>> source library projects. Currently our focus is on the .NET platform >>>> and tools supporting Microsoft's symsrv technology - >>>> Visual Studio, WinDbg and others. >>>> >>>> To use it you need to configure a symbol server the same way you do >>>> for the Reference Source server from Microsoft. Then you'll be able to >>>> debug NHibernate source code from within your own projects that use >>>> it. Instructions for configuring Visual Studio are provided on the >>>> website. >>>> >>>> Best regards, >>>> Marcin Mikołajczak >>>> Co-founder of SymbolSource.org >>>> [email protected] >>>> >>> >>> >>> >>> -- >>> Fabio Maulo >>> >>> >> > -- Fabio Maulo
