Hi Chris,
Obviously nobody can guarantee that a patch will be accepted. Your best bet
is to do address each (ideally small) issue one at a time, and provide test
cases with all patches.
If there isn't actually a bug, then I suspect more detail would be helpful.
Probably as an improvement in JIRA.
Cheers,
Richard
--------------------------------------------------
From: "Chris Collier" <[email protected]>
Sent: Thursday, March 04, 2010 9:43 PM
To: "nhibernate-development" <[email protected]>
Subject: [nhibernate-development] hbm2ddl patch; proposal for more
comprehensive work
I recently submitted this patch: http://216.121.112.228/browse/NH-2126,
which I needed for work on the product my team is building using NH.
In getting into the code, it looks like the hbm2ddl code could use a
more complete fix to the issue I addressed: IDbCommand objects not
being created using the same mechanisms the rest of NH uses (when
appropriate).
In my opinion, the way the Execute(...) methods are chained could use
some cleaning up as well.
I'd like to invest some time in giving some TLC to the hbm2ddl code --
does anyone support this effort, i.e., if I do it, assuming it's
quality code, what are the chances that these hbm2ddl cleanups would
be considered a worthwhile effort for 3.0? I can give more detail
about my planned changes if wanted. Please advise.
Thanks
Chris
