I think the code's wrong ... but don't worry - I won't be changing it till I've got a failing test first.
From: Fabio Maulo Sent: Monday, March 29, 2010 8:58 PM To: [email protected] Subject: Re: [nhibernate-development] Re: SetMaxResults Ok but I would see the dialect in use and read the documentation of the RDBMS. To manage pagination the problem is in the dialect believe me. 2010/3/29 Richard Brown (gmail) <[email protected]> Hi, I notice my name is next to that line of code (from r4158) in an SVN blame - and it does look wrong. (Loader.cs from trunk, line 1267.) However, in the current trunk no test calls that function with startIndex > 0, so it's impossible (for me) to verify using the current tests. (i.e., The tests will all pass if we change this from 0 to startIndex.) I suspect we ideally need to maintain the tests that run against another database/dialect. Brian, If you raise a JIRA (and even better if someone can create a failing test case) I'll have a look into it. Fabio, I was just wondering if there's any scope for installing any other databases on the CI server? (To try and give us better coverage for paging examples on each dialect?) > > > > 2010/3/29 brianw <[email protected]> > > > > > > > queryParameters.BindParameters(statement, GetNamedParameterLocs, 0, > > > > > session); > > > > > perhaps should be > > > > > queryParameters.BindParameters(statement, GetNamedParameterLocs, > > > > > startIndex, session); > To unsubscribe from this group, send email to nhibernate-development+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject. -- Fabio Maulo To unsubscribe from this group, send email to nhibernate-development+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject. To unsubscribe from this group, send email to nhibernate-development+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
<<Emoticon3.gif>>
