I concur with you on making it settable through merged properties. I am surprised why it is not already.
On Thu, Jul 29, 2010 at 2:50 PM, James Gregory <[email protected]>wrote: > Hey guys, > > We've been hitting some command timeouts recently in our system, and > it appears our command_timeout setting isn't being honoured. After > investigating, it seems the SqlClientBatchingBatcher only gets the > command_timeout value directly from the Environment settings (which > comes from a web/app.config section, rather than your hibernate.xml). > Shouldn't it be getting that setting from the merged properties > dictionary like the other classes? > > The code in question is below: > > private void SetCommandTimeout() > { > int timeout = > PropertiesHelper.GetInt32(Cfg.Environment.CommandTimeout, > Cfg.Environment.Properties, -1); > > if (timeout > 0) > { > try > { > currentBatch.CommandTimeout = timeout; > } > catch (Exception e) > { > if (log.IsWarnEnabled) > { > log.Warn(e.ToString()); > } > } > } > } > > Shouldn't the command_timeout setting be settable from the > hibernate.xml file too? > > I don't mind creating a patch/jira/whatever, but I just wanted to make > sure this isn't by design. > > Thanks, > James -- Sidar Ok http://www.sidarok.com http://www.twitter.com/sidarok
