I've been on vacation for the last week and couldn't work on the
patch. In any case, the patch for NH-2279 is there now. I just
realized I forgot to put back the one line comment in the ReadFrom
method. Let me know if you want me to update the patch for that. The
original PersistentIdentifierBag code seemed to have voodoo magic
going on... some of it definitely broken. After studying the use of
the identifiers array, I think the new code is sane. At least it
passes the unit tests, doing better than the old code.
Looking forward to review of NH-2111, NH-2278, and especially the
voodoo-magic-elimination-patch NH-2279.
Patrick Earl
On Aug 15, 7:24 pm, Fabio Maulo <[email protected]> wrote:
> I personally reviewed your 4 issues..
> In the last you said something about a patch. I'll check when it will be
> there.
>
> --
> Fabio Maulo
>
> El 15/08/2010, a las 16:06, Patrick Earl <[email protected]> escribió:
>
>
>
> > Hello once again. :)
>
> > I wanted to put in a note that might help the poor IdBag get a bit of
> > attention. It would be great if somebody could take a look at NH-2111
> > and NH-2278. They are short but important bug fixes that come with
> > tests. I'm working on the fixes for 2279, but it's a slower process.
> > I'd appreciate it if these old bugs could be fixed. I updated the
> > NH-2111 and NH-2278 patches for the trunk recently, but they are
> > starting to age already.
>
> > Thanks for the consideration.
>
> > Patrick Earl
