I noticed a couple of naming issues on the ByCode mapping API:

1) ModelMapper.CompileMappingForAllExplicitAddedEntities -> better as 
CompileMappingForAllExplicitlyAddedEntities?
2) ModelMapper.CompileMappingForEachExplicitAddedEntity -> better as 
CompileMappingForEachExplicitlyAddedEntity?
3) IModelInspector.GetPropertiesSplits -> GetPropertySplits or 
GetPropertysSplits?
4) References to 'ComposedIds' mean 'CompositeIds'?

For 1) and 2) it is better to say 'Explicitly' rather than 'Explicit', 
although it is possible to get away with the current naming if there is a 
real desire to save two characters in length :)

Regarding 3), I'm not sure I understand the concept of 'splits' in the code. 
It refers to <join> mappings I think? However, when I mapped a Join, the 
parameter name for the table was 'splitGroupId' which seemed unintuitive.

Best to make any changes (if required) now than later...

Reply via email to