So under this proposed change if Log4Net was in the GAC but you didn't want any logging you would have to explicitly configure NH for the NoLoggingLogger, is that right?
Steve Bohlen [email protected] http://blog.unhandled-exceptions.com http://twitter.com/sbohlen On Tue, Jan 24, 2012 at 8:03 AM, Richard Brown (gmail) < [email protected]> wrote: > I think it still won’t be required, it’s just that it will now be > located if it’s in the GAC? > > Sounds ok to me as long as it still reverts to the NoLoggingLogger when > log4net isn’t in the deploy folder or the GAC. > > *From:* Fabio Maulo <[email protected]> > *Sent:* Tuesday, January 24, 2012 2:00 AM > *To:* [email protected] > *Subject:* Re: [nhibernate-development] Regarding NH-2821 - better way of > finding log4net > If no logging system is configured and there isn't log4net in the deploy > folder the NoLoggingLogger is used.. > In practice log4net should always not to be required > > On Mon, Jan 23, 2012 at 7:03 PM, Oskar Berggren > <[email protected]>wrote: > >> A pull request was submitted last year that delegates finding log4net to >> .Net. >> >> https://github.com/nhibernate/nhibernate-core/pull/15 >> >> It was not merged at the time because there was some compatibility >> concerns since if log4net was installed in the GAC, NHibernate would >> now suddenly find this. Someone mentioned delaying it until the next >> major version. >> >> Since we are now aiming for 3.3, perhaps we should try to make a >> decision on this. >> >> >> Since we are only trying to load log4net if no other logging framework >> has been configured, I think the proposed change would be ok. Also, >> before the introduction of the logging abstraction, log4net would >> always be loaded even when not configured. >> >> >> /Oskar >> > > > > -- > Fabio Maulo > >
