Hi Oscar, I can understand the rationale and wisdom of postponing any merging until post 3.3. For ourselves the timing is not that important, as we run against a private NH build. However, it makes life a lot smoother when patches ultimately make it into the trunk. Many thanks, Gerke.
On Tuesday, 13 March 2012 19:35:33 UTC+1, Oskar Berggren wrote: > Hi Gerke, > > Thanks for your work on this. In my opinion it feels a bit late for > this in 3.3. I realise your patches for this has been available for > some time, but unfortunately there has not been time to review and > merge it. The 3.3.0 release is long overdue already and I feel > uncomfortable in bringing in this much code without doing a new > candidate release which would delay the final release further (and all > the fixes already in there). > > We have not yet discussed the release schedule for coming releases, > but I myself think we should try to release more often - perhaps a > 3.3.1 in a few months time. > > /Oskar > > > 2012/3/13 Gerke Geurts <[email protected]>: > > Hello all, > > > > I have updated pull request > > https://github.com/nhibernate/nhibernate-core/pull/63 for > > https://nhibernate.jira.com/browse/NH-2977 with a MsSql2012Dialect > > implementation and associated tests that also covers > > https://nhibernate.jira.com/browse/NH-3038. > > > > It would be great if this fix could still be considered/reviewed for NH > 3.3. > > > > Kind Regards, > > Gerke. > > > > On Thursday, 16 February 2012 22:05:02 UTC+1, CSharper wrote: > >> > >> I've seen that there is a jira issue now: > >> https://nhibernate.jira.com/browse/NH-3038 > >> And so I created a pull request: > >> https://github.com/nhibernate/nhibernate-core/pull/78 > >
