Hi,

I came across an editor-agnostic system for declaring whether a project
uses tab or space indentation and automatically switching that editor
between modes. It's called editorconfig and has a Visual Studio plugin
available in the Extensions Manager gallery.

Does anyone think an editorconfig configuration this would be good to add
to NHibernate? I've opened a pull request containing the config file and
updated the contributor guide. Thoughts?

https://github.com/nhibernate/nhibernate-core/pull/122

Find out more at:

http://editorconfig.org/
https://github.com/editorconfig


Richard

On Tue, May 15, 2012 at 7:06 AM, Richard Birkby <[email protected]> wrote:

> I think that's a good idea. Perhaps with a batch file to launch vs using
> these settings?
>
> Richard
>
> On 15 May 2012, at 06:55, cremor <[email protected]> wrote:
>
> What do you think about providing an exported Visual Studio settings file
> in the repository that contains correct C# (and maybe XML and VB) text
> editor settings? That way we could just import the settings and be sure
> that the coding standards are met (at least those that are controlled by VS
> settings).
>
> On Tuesday, January 3, 2012 1:45:19 AM UTC+1, Julian Maughan wrote:
>>
>> Tabs should be used. NHibernate mostly follows MS's coding guidelines -
>> as enforced by tools like FxCop and ReSharper:
>>
>> http://msdn.microsoft.com/en-us/library/xzf533w0(v=VS.71).aspx
>>
>> Unfortunately there are some variations, and although I'm quite active in
>> trying to standardize as much as possible its a thankless task. For
>> example, I prefer field names to use underscore-camel notation, and
>> generally convert existing code to this - particularly if there is
>> inconsistency within a class.
>> On 03/01/2012 12:42 AM, "CSharper" <[email protected]> wrote:
>>
>>> Hi,
>>>
>>> where can I find some information about coding standards in
>>> NHibernate? Are they written down somewhere?
>>>
>>> The easiest thing: should tabs or spaces be used for line indentation?
>>> I've browsed some recent changes on the git repository and some pull
>>> requests and the diffs there are often much larger than they would
>>> have to be because there is a switch between tabs and spaces in the
>>> files. That makes reading patches much harder. O.k., an external diff
>>> program ignoring whitespace differences helps on the local machine but
>>> for browsing the repository online, there's no easy solution.
>>>
>>

Reply via email to